From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chase Douglas Subject: Re: [PATCH v2 4/7] Input: ALPS - Remove assumptions about packet size Date: Mon, 07 Nov 2011 13:31:59 -0800 Message-ID: <4EB84E4F.5020502@canonical.com> References: <1320699160-28492-1-git-send-email-seth.forshee@canonical.com> <1320699160-28492-5-git-send-email-seth.forshee@canonical.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from youngberry.canonical.com ([91.189.89.112]:42216 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751319Ab1KGVcG (ORCPT ); Mon, 7 Nov 2011 16:32:06 -0500 In-Reply-To: <1320699160-28492-5-git-send-email-seth.forshee@canonical.com> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Seth Forshee Cc: Dmitry Torokhov , Alessandro Rubini , Henrik Rydberg , Andrew Skalski , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org On 11/07/2011 12:52 PM, Seth Forshee wrote: > In preparation for version 4 protocol support, which has 8-byte > data packets, remove all hard-coded assumptions about packet size > and use psmouse->pktsize instead. > > Signed-off-by: Seth Forshee The stack allocated buffer is much cleaner :). Acked-by: Chase Douglas