From: "H. Peter Anvin" <hpa@zytor.com>
To: Bryan Freed <bfreed@chromium.org>
Cc: Kees Cook <keescook@chromium.org>,
linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
msb@chromium.org, marco.stornelli@gmail.com,
seiji.aguchi@hds.com, tony.luck@intel.com
Subject: Re: [PATCH] ramoops: Add a device file for ramoops buffer access.
Date: Mon, 07 Nov 2011 17:33:22 -0800 [thread overview]
Message-ID: <4EB886E2.1000504@zytor.com> (raw)
In-Reply-To: <CAEYUcX3wKfQZGFbRuRHgE8wuc_=Jm+-9s68tb20jkd_yqRHOjA@mail.gmail.com>
As I mentioned to Kees on IRC, you probably want to talk to Tony Luck
about his pstore interface, too.
On 11/07/2011 05:04 PM, Bryan Freed wrote:
> Yeah, we should definitely work together on this.
>
> bryan.
>
> On Mon, Nov 7, 2011 at 4:36 PM, Kees Cook <keescook@chromium.org> wrote:
>> Hi Bryan,
>>
>> On Mon, Nov 07, 2011 at 04:06:00PM -0800, Bryan Freed wrote:
>>> Add a /dev/ramoops device file that gives direct access to ramoops buffers.
>>> This interface is cleaner than using /dev/mem to access the buffers because
>>> we no longer need to lseek() or (for ARM) mmap() to an address specified in
>>> the sysfs mem_address file.
>>
>> This looks pretty good, except that I'd also want to remove all the module
>> parameters since this would bypass CONFIG_STRICT_DEVMEM (imagine a
>> malicious root user loading this module to spy on RAM via the new
>> interface).
>>
>> Last week I actually wrote an entire seq_file interface for ramoops[1], but
>> it seems it shouldn't live in /proc, so it needs to be reworked a bit to
>> live in /dev, as you have it.
>>
>> Perhaps we could merge our efforts?
>>
>> -Kees
>>
>> [1] https://gerrit.chromium.org/gerrit/#change,11242
>>
>> --
>> Kees Cook
>> ChromeOS Security
>>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2011-11-08 1:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-08 0:06 [PATCH] ramoops: Add a device file for ramoops buffer access Bryan Freed
2011-11-08 0:14 ` Alan Cox
2011-11-08 0:36 ` Kees Cook
2011-11-08 1:04 ` Bryan Freed
2011-11-08 1:33 ` H. Peter Anvin [this message]
2011-11-08 7:58 ` Marco Stornelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EB886E2.1000504@zytor.com \
--to=hpa@zytor.com \
--cc=akpm@linux-foundation.org \
--cc=bfreed@chromium.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marco.stornelli@gmail.com \
--cc=msb@chromium.org \
--cc=seiji.aguchi@hds.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.