Re: [LTP] [PATCH] recvmsg01: kill child only if one was forked

[Wanlong Gao <gaowanlong@cn.fujitsu.com>]

On 11/08/2011 03:14 PM, Jan Stancek wrote:

> 
> 
> ----- Original Message -----
>> From: "Wanlong Gao" <gaowanlong@cn.fujitsu.com>
>> To: "Jan Stancek" <jstancek@redhat.com>
>> Cc: ltp-list@lists.sourceforge.net
>> Sent: Tuesday, November 8, 2011 4:07:56 AM
>> Subject: Re: [LTP] [PATCH] recvmsg01: kill child only if one was forked
>>
>> On 11/07/2011 08:53 PM, Jan Stancek wrote:
>>
>>>
>>> If start_server() fails, then pid will end up with -1 and
>>> cleanup() will do kill(-1, SIGKILL), which kills everything
>>> this process can kill.
>>>
>>> Change the test to kill pid (child) only when it successfully
>>> creates one.
>>>
>>
>>
>> Yeah, but this can't fix the problem in this case?
>>
>> recvmsg01    1  TBROK  :  server bind failed: errno=???(98): Address
>> already in use
>> recvmsg01    2  TBROK  :  Remaining cases broken
>>
> 
> I'm not sure I follow you here.
> In case you described start_server() returns -1,
> so pid = -1, and cleanup won't do kill(-1, SIGKILL).
> 


Yeah, I understood you.

But we wanna fix the case to TPASS but not TBROK, do we?
So, I mean that the issues of this case is not only what you said.

Thanks
-Wanlong Gao

------------------------------------------------------------------------------
RSA(R) Conference 2012
Save $700 by Nov 18
Register now
http://p.sf.net/sfu/rsa-sfdev2dev1
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list