All of lore.kernel.org
 help / color / mirror / Atom feed
From: HAYASAKA Mitsuo <mitsuo.hayasaka.hu@hitachi.com>
To: Pekka Enberg <penberg@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
	Randy Dunlap <rdunlap@xenotime.net>,
	x86@kernel.org, linux-kernel@vger.kernel.org,
	linux-doc@vger.kernel.org, yrl.pp-manager.tt@hitachi.com
Subject: Re: [RFC PATCH 0/5] x86: check stack overflows more reliably
Date: Tue, 08 Nov 2011 16:34:28 +0900	[thread overview]
Message-ID: <4EB8DB84.6070300@hitachi.com> (raw)
In-Reply-To: <CAOJsxLGH6maRZPx0TX4r6Zy=AiXQMRssoySeOmjn02O-BkBDEA@mail.gmail.com>

Hi Pekka,

Thank you for your comments.

(2011/11/07 16:00), Pekka Enberg wrote:
> On Mon, Nov 7, 2011 at 7:51 AM, Mitsuo Hayasaka
> <mitsuo.hayasaka.hu@hitachi.com> wrote:
>> (2) check stack overflow in detail
>>    Currently, only kernel stack is checked for the overflow,
>>    which is not sufficient for enterprise systems. To enhance
>>    reliability, expand stack overflow checking to IRQ and
>>    exception stacks optionally. This is disabled by default
>>    in Kconfig.
> 
> This sounds useful. What's the reason for not enabling this by
> default? Performance regressions?

I'm worried about performance regressions because this patch checks 
a stack overflow in detail.

However, I guess there is no problem for enabling it by default 
since this option is for debug and appears only if a DEBUG_STACKOVERFLOW
option is enabled.

So, I'd like to send the revised patch if it does not have any further problem.


>                         Pekka
> 
> 


  reply	other threads:[~2011-11-08  7:34 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-07  5:51 [RFC PATCH 0/5] x86: check stack overflows more reliably Mitsuo Hayasaka
2011-11-07  5:52 ` [RFC PATCH 1/5] x86: add user_mode_vm check in stack_overflow_check Mitsuo Hayasaka
2011-11-10 19:52   ` Konrad Rzeszutek Wilk
2011-11-15  5:47     ` HAYASAKA Mitsuo
2011-11-07  5:52 ` [RFC PATCH 2/5] x86: check stack overflow in detail Mitsuo Hayasaka
2011-11-07  5:53 ` [RFC PATCH 3/5] x86: add a sysctl parameter to panic on stack overflow Mitsuo Hayasaka
2011-11-10 19:55   ` Konrad Rzeszutek Wilk
2011-11-15  5:51     ` HAYASAKA Mitsuo
2011-11-17  7:11     ` HAYASAKA Mitsuo
2011-11-17 16:00       ` Konrad Rzeszutek Wilk
2011-11-17 16:06         ` H. Peter Anvin
2011-11-07  5:53 ` [RFC PATCH 4/5] x86: panic on detection of " Mitsuo Hayasaka
2011-11-10 19:59   ` Konrad Rzeszutek Wilk
2011-11-15  5:53     ` HAYASAKA Mitsuo
2011-11-07  5:53 ` [RFC PATCH 5/5] x86: change range of stack overflow checking Mitsuo Hayasaka
2011-11-07  7:00 ` [RFC PATCH 0/5] x86: check stack overflows more reliably Pekka Enberg
2011-11-08  7:34   ` HAYASAKA Mitsuo [this message]
2011-11-17 16:59     ` Jason Baron
2011-11-23  8:55       ` HAYASAKA Mitsuo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EB8DB84.6070300@hitachi.com \
    --to=mitsuo.hayasaka.hu@hitachi.com \
    --cc=hpa@zytor.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=penberg@kernel.org \
    --cc=rdunlap@xenotime.net \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    --cc=yrl.pp-manager.tt@hitachi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.