From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Hellstrom Subject: Re: [PATCH 09/12] ttm: Provide DMA aware TTM page pool code. Date: Tue, 08 Nov 2011 09:51:56 +0100 Message-ID: <4EB8EDAC.2050005@vmware.com> References: <1320709232-29477-1-git-send-email-j.glisse@gmail.com> <1320709232-29477-10-git-send-email-j.glisse@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from smtp-outbound-1.vmware.com (smtp-outbound-1.vmware.com [65.115.85.69]) by gabe.freedesktop.org (Postfix) with ESMTP id DF6D6A0240 for ; Tue, 8 Nov 2011 00:54:29 -0800 (PST) In-Reply-To: <1320709232-29477-10-git-send-email-j.glisse@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: j.glisse@gmail.com Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org .... On 11/08/2011 12:40 AM, j.glisse@gmail.com wrote: > diff --git a/include/drm/ttm/ttm_bo_driver.h b/include/drm/ttm/ttm_bo_driver.h > index ae06e42..beef9ab 100644 > --- a/include/drm/ttm/ttm_bo_driver.h > +++ b/include/drm/ttm/ttm_bo_driver.h > @@ -104,6 +104,7 @@ enum ttm_caching_state { > * @caching_state: The current caching state of the pages. > * @state: The current binding state of the pages. > * @dma_address: The DMA (bus) addresses of the pages (if TTM_PAGE_FLAG_DMA32) > + * @alloc_list: used by some page allocation backend > As mentioned in the comment to patch 7, could we put this in a struct ttm_dma_tt, which embeds struct ttm_tt? > * > * This is a structure holding the pages, caching- and aperture binding > * status for a buffer object that isn't backed by fixed (VRAM / AGP) > @@ -127,6 +128,7 @@ struct ttm_tt { > tt_unpopulated, > } state; > dma_addr_t *dma_address; > + struct list_head alloc_list; > }; > >