From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 2/2] ac97: don't override the pci subsystem id Date: Tue, 08 Nov 2011 12:00:55 +0200 Message-ID: <4EB8FDD7.30909@redhat.com> References: <1320679989-8274-1-git-send-email-kraxel@redhat.com> <1320679989-8274-2-git-send-email-kraxel@redhat.com> <4EB80099.8050304@codemonkey.ws> <4EB8E38D.6040804@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Takashi Iwai , qemu-devel@nongnu.org, kvm@vger.kernel.org To: Gerd Hoffmann Return-path: In-Reply-To: <4EB8E38D.6040804@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org List-Id: kvm.vger.kernel.org On 11/08/2011 10:08 AM, Gerd Hoffmann wrote: > On 11/07/11 17:00, Anthony Liguori wrote: > > On 11/07/2011 09:33 AM, Gerd Hoffmann wrote: > >> This patch removes the code lines which set the subsystem id for the > >> emulated ac97 card to 8086:0000. Due to the device id being zero the > >> subsystem id isn't vaild anyway. With the patch applied the sound card > >> gets the default qemu subsystem id (1af4:1100) instead. > > > > I don't like having a property of "use broken". > > Well, it *is* broken. > Suggestions for a better name? correctness_challenged? legacy? > > Wouldn't it be better to have the subsystem vendor and device id be > > configurable, set the default to the qemu subsystem ids, and then set it > > to 8086:0000 for < 1.0? > > I don't want this being fully configurable just for the snake of > backward compatibility with old qemu versions. I imagine some downstreams will want to configure it, but if we ever do that, it's not for 1.0. -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain. From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:52159) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RNiUd-0001cA-8E for qemu-devel@nongnu.org; Tue, 08 Nov 2011 05:01:24 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RNiUX-00033D-D2 for qemu-devel@nongnu.org; Tue, 08 Nov 2011 05:01:23 -0500 Received: from mx1.redhat.com ([209.132.183.28]:45573) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RNiUX-000333-3c for qemu-devel@nongnu.org; Tue, 08 Nov 2011 05:01:17 -0500 Message-ID: <4EB8FDD7.30909@redhat.com> Date: Tue, 08 Nov 2011 12:00:55 +0200 From: Avi Kivity MIME-Version: 1.0 References: <1320679989-8274-1-git-send-email-kraxel@redhat.com> <1320679989-8274-2-git-send-email-kraxel@redhat.com> <4EB80099.8050304@codemonkey.ws> <4EB8E38D.6040804@redhat.com> In-Reply-To: <4EB8E38D.6040804@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/2] ac97: don't override the pci subsystem id List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: Takashi Iwai , qemu-devel@nongnu.org, kvm@vger.kernel.org On 11/08/2011 10:08 AM, Gerd Hoffmann wrote: > On 11/07/11 17:00, Anthony Liguori wrote: > > On 11/07/2011 09:33 AM, Gerd Hoffmann wrote: > >> This patch removes the code lines which set the subsystem id for the > >> emulated ac97 card to 8086:0000. Due to the device id being zero the > >> subsystem id isn't vaild anyway. With the patch applied the sound card > >> gets the default qemu subsystem id (1af4:1100) instead. > > > > I don't like having a property of "use broken". > > Well, it *is* broken. > Suggestions for a better name? correctness_challenged? legacy? > > Wouldn't it be better to have the subsystem vendor and device id be > > configurable, set the default to the qemu subsystem ids, and then set it > > to 8086:0000 for < 1.0? > > I don't want this being fully configurable just for the snake of > backward compatibility with old qemu versions. I imagine some downstreams will want to configure it, but if we ever do that, it's not for 1.0. -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.