From: nicolas.ferre@atmel.com (Nicolas Ferre)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] at91: fix compile breakage with VMALLOC_END
Date: Tue, 08 Nov 2011 11:54:00 +0100 [thread overview]
Message-ID: <4EB90A48.6060308@atmel.com> (raw)
In-Reply-To: <1320748119-16270-1-git-send-email-jamie.iles@mathembedded.com>
On 11/08/2011 11:28 AM, Jamie Iles :
> From: Jamie Iles <jamie@jamieiles.com>
>
> VMALLOC_END is defined in terms of AT91_VIRT_BASE but this needs
> mach/hardware.h for it's definition.
>
> In file included from arch/arm/mach-at91/board-usb-a926x.c:26:0:
> include/linux/mm.h: In function 'is_vmalloc_addr':
> include/linux/mm.h:305:41: error: 'AT91_VIRT_BASE' undeclared (first use in this function)
> include/linux/mm.h:305:41: note: each undeclared identifier is reported only once for each function it appears in
>
> Cc: Nicolas Ferre <nicolas.ferre@atmel.com>
> Cc: Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>
> Signed-off-by: Jamie Iles <jamie@jamieiles.com>
Jean-Christophe already posted the very same patch for this. But maybe
he can take your description...
Best regards,
> ---
>
> This is a bit more heavyweight than most of the other platforms,
> but it's the simplest fix.
>
> arch/arm/mach-at91/include/mach/vmalloc.h | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-at91/include/mach/vmalloc.h b/arch/arm/mach-at91/include/mach/vmalloc.h
> index 8eb459f..8e4a1bd 100644
> --- a/arch/arm/mach-at91/include/mach/vmalloc.h
> +++ b/arch/arm/mach-at91/include/mach/vmalloc.h
> @@ -21,6 +21,8 @@
> #ifndef __ASM_ARCH_VMALLOC_H
> #define __ASM_ARCH_VMALLOC_H
>
> +#include <mach/hardware.h>
> +
> #define VMALLOC_END (AT91_VIRT_BASE & PGDIR_MASK)
>
> #endif
--
Nicolas Ferre
prev parent reply other threads:[~2011-11-08 10:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-08 10:28 [PATCH] at91: fix compile breakage with VMALLOC_END Jamie Iles
2011-11-08 10:54 ` Nicolas Ferre [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EB90A48.6060308@atmel.com \
--to=nicolas.ferre@atmel.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.