From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH] x86/IRQ: create_irq() should
	call	assign_irq_vector()
Date: Tue, 8 Nov 2011 12:03:27 +0000
Message-ID: <4EB91A8F.8060101@citrix.com>
References: <4EB915B7020000780005F8FC@novprvoes0310.provo.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="ISO-8859-1"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <4EB915B7020000780005F8FC@novprvoes0310.provo.novell.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: xen-devel@lists.xensource.com
List-Id: xen-devel@lists.xenproject.org

On 08/11/11 10:42, Jan Beulich wrote:
> ... rather than __assign_irq_vector(), to ensure desc->affinity gets
> initialized properly.
>
> This at once eliminates the need to forward-declare the latter function.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>

> --- a/xen/arch/x86/irq.c
> +++ b/xen/arch/x86/irq.c
> @@ -25,7 +25,6 @@
>  #include <public/physdev.h>
>  
>  static void parse_irq_vector_map_param(char *s);
> -static int __assign_irq_vector(int irq, struct irq_desc *, const cpumask_t *);
>  
>  /* opt_noirqbalance: If true, software IRQ balancing/affinity is disabled. */
>  bool_t __read_mostly opt_noirqbalance = 0;
> @@ -153,7 +152,6 @@ int __init bind_irq_vector(int irq, int 
>   */
>  int create_irq(void)
>  {
> -    unsigned long flags;
>      int irq, ret;
>      struct irq_desc *desc;
>  
> @@ -169,11 +167,7 @@ int create_irq(void)
>  
>      ret = init_one_irq_desc(desc);
>      if (!ret)
> -    {
> -        spin_lock_irqsave(&vector_lock, flags);
> -        ret = __assign_irq_vector(irq, desc, TARGET_CPUS);
> -        spin_unlock_irqrestore(&vector_lock, flags);
> -    }
> +        ret = assign_irq_vector(irq);
>      if (ret < 0)
>      {
>          desc->arch.used = IRQ_UNUSED;
>
>
>

-- 
Andrew Cooper - Dom0 Kernel Engineer, Citrix XenServer
T: +44 (0)1223 225 900, http://www.citrix.com