All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anthony Liguori <anthony@codemonkey.ws>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1.0] disable automatic loading of sgabios when -nographic
Date: Tue, 08 Nov 2011 11:23:44 -0600	[thread overview]
Message-ID: <4EB965A0.5050701@codemonkey.ws> (raw)
In-Reply-To: <1320332422-2457-1-git-send-email-pbonzini@redhat.com>

On 11/03/2011 10:00 AM, Paolo Bonzini wrote:
> sgabios hasn't gotten a lot of coverage since it was not shipped.  For 1.0,
> let's disable the automatic loading of the option ROM in -nographic
> mode.  We can put it back for 1.1.
>
> Signed-off-by: Paolo Bonzini<pbonzini@redhat.com>

Applied.  Thanks.

Regards,

Anthony Liguori

> ---
> 	Requested by Anthony on IRC.
>
>   hw/pc.c |    9 ---------
>   1 files changed, 0 insertions(+), 9 deletions(-)
>
> diff --git a/hw/pc.c b/hw/pc.c
> index eb4c2d8..1024465 100644
> --- a/hw/pc.c
> +++ b/hw/pc.c
> @@ -1104,15 +1104,6 @@ void pc_vga_init(PCIBus *pci_bus)
>               isa_vga_init();
>           }
>       }
> -
> -    /*
> -     * sga does not suppress normal vga output. So a machine can have both a
> -     * vga card and sga manually enabled. Output will be seen on both.
> -     * For nographic case, sga is enabled at all times
> -     */
> -    if (display_type == DT_NOGRAPHIC) {
> -        isa_create_simple("sga");
> -    }
>   }
>
>   static void cpu_request_exit(void *opaque, int irq, int level)

  reply	other threads:[~2011-11-08 17:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-03 15:00 [Qemu-devel] [PATCH 1.0] disable automatic loading of sgabios when -nographic Paolo Bonzini
2011-11-08 17:23 ` Anthony Liguori [this message]
2011-12-02 16:33   ` Paolo Bonzini
2011-12-02 16:34     ` Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EB965A0.5050701@codemonkey.ws \
    --to=anthony@codemonkey.ws \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.