From: Scott Wood <scottwood@freescale.com>
To: Li Yang-R58472 <r58472@freescale.com>
Cc: Wood Scott-B07421 <B07421@freescale.com>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
Zhao Chenhui-B35336 <B35336@freescale.com>
Subject: Re: [PATCH 3/7] powerpc/85xx: add sleep and deep sleep support
Date: Tue, 8 Nov 2011 11:31:27 -0600 [thread overview]
Message-ID: <4EB9676F.4080509@freescale.com> (raw)
In-Reply-To: <3F607A5180246847A760FD34122A1E052BC91C@039-SN1MPN1-004.039d.mgd.msft.net>
On 11/08/2011 04:32 AM, Li Yang-R58472 wrote:
>> Subject: Re: [PATCH 3/7] powerpc/85xx: add sleep and deep sleep support
>>
>> On 11/04/2011 07:33 AM, Zhao Chenhui wrote:
>>> static int pmc_suspend_enter(suspend_state_t state)
>>> {
>>> int ret;
>>> + u32 powmgtreq = 0x00500000;
>>
>> Where does this 0x00500000 come from? Please symbolically define
>> individual bits.
>>
>> The comment in the asm code says it should be 0x00100000, BTW.
>
> I think we should get rid of the powmgtreq argument, as we don't support multiple modes for mpc85xx_enter_deep_sleep() now.
Doesn't that happen later in the patch series?
-Scott
next prev parent reply other threads:[~2011-11-08 17:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-04 12:33 [PATCH 3/7] powerpc/85xx: add sleep and deep sleep support Zhao Chenhui
2011-11-04 17:36 ` Felix Radensky
2011-11-08 10:27 ` Li Yang-R58472
2011-11-04 18:45 ` Scott Wood
2011-11-08 10:32 ` Li Yang-R58472
2011-11-08 17:31 ` Scott Wood [this message]
2011-11-04 22:43 ` Felix Radensky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EB9676F.4080509@freescale.com \
--to=scottwood@freescale.com \
--cc=B07421@freescale.com \
--cc=B35336@freescale.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=r58472@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.