From: Ben Greear <greearb@candelatech.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH v8 2/2] mac80211: Support ht-cap over-rides.
Date: Tue, 08 Nov 2011 12:44:17 -0800 [thread overview]
Message-ID: <4EB994A1.1020808@candelatech.com> (raw)
In-Reply-To: <1320782949.24797.45.camel@jlt3.sipsolutions.net>
On 11/08/2011 12:09 PM, Johannes Berg wrote:
> On Tue, 2011-11-08 at 11:36 -0800, greearb@candelatech.com wrote:
>
>> + /*
>> + * We always need to advert at least MCS0-7, to
>> + * be a compliant HT station, for instance
>> + */
>> + if (((i * 8 + q)>= min_rates)&&
>
> This is a little misleading -- why min_rates when the comment says
> MCS0-7?
I let caller determine the min, but comment was to tell why
the min might be set. In APs, the min supported rates are 16, evidently...not
that this code supports APs at the moment...
When this is about local use instead of advertising, then any minimum
is OK.
Want me to just remove the comment entirely?
Thanks,
Ben
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
next prev parent reply other threads:[~2011-11-08 20:44 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-08 19:36 [PATCH v8 1/2] wireless: Support ht-capabilities over-rides greearb
2011-11-08 19:36 ` [PATCH v8 2/2] mac80211: Support ht-cap over-rides greearb
2011-11-08 20:09 ` Johannes Berg
2011-11-08 20:44 ` Ben Greear [this message]
2011-11-08 20:58 ` Johannes Berg
2011-11-08 21:00 ` Johannes Berg
2011-11-08 21:06 ` Ben Greear
2011-11-08 21:08 ` Johannes Berg
2011-11-08 20:12 ` Johannes Berg
2011-11-08 20:17 ` Johannes Berg
2011-11-08 20:58 ` Ben Greear
2011-11-08 21:02 ` Johannes Berg
2011-11-08 23:11 ` Ben Greear
2011-11-09 8:37 ` Johannes Berg
2011-11-10 19:25 ` Ben Greear
2011-11-17 11:28 ` Johannes Berg
2011-11-17 17:22 ` Ben Greear
2011-11-17 17:25 ` Johannes Berg
2011-11-17 17:42 ` Ben Greear
2011-11-08 20:07 ` [PATCH v8 1/2] wireless: Support ht-capabilities over-rides Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EB994A1.1020808@candelatech.com \
--to=greearb@candelatech.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.