From: Saul Wold <sgw@linux.intel.com>
To: McClintock Matthew-B29882 <B29882@freescale.com>,
Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH v2] Introduce new SERIAL_CONSOLES to add multiple consoles for your MACHINE
Date: Tue, 08 Nov 2011 13:06:49 -0800 [thread overview]
Message-ID: <4EB999E9.30306@linux.intel.com> (raw)
In-Reply-To: <CAEsOVNfyeYRkEhL1LD1GYBrxqdvNEkjbG5fWgwpTRH_UEyxedA@mail.gmail.com>
On 11/08/2011 12:50 PM, McClintock Matthew-B29882 wrote:
> On Tue, Nov 8, 2011 at 2:47 PM, Phil Blundell<philb@gnu.org> wrote:
>> On Tue, 2011-11-08 at 19:36 +0000, McClintock Matthew-B29882 wrote:
>>> On Mon, Nov 7, 2011 at 5:03 PM, Matthew McClintock<msm@freescale.com> wrote:
>>>> I don't get it. I think the first version was still OK. The first
>>>> version is pasted below.
>>>>
>>>>> + idx=0
>>>>> + tmp="${SERIAL_CONSOLES}"<- If it's not defined this will catch it.
>>>>> + for i in $tmp
>>>>> + do
>>>>> + j=`echo ${i} | sed s/\;/\ /g`
>>>>> + echo "${idx}:2345:respawn:${base_sbindir}/getty ${j}">> ${D}${sysconfdir}/inittab
>>>>> + idx=`expr $idx + 1`
>>>>> + done
>>>>
>>>> See my inline comment above, but if SERIAL_CONSOLES is not defined
>>>> tmp="" and the for loop won't execute. Not sure if there is a more
>>>> standard way to do this though.
>>>
>>> ping..
>>
>> Yeah, now I look at this again I think it is probably OK. Bitbake won't
>> expand ${SERIAL_CONSOLES} if it's unset, but the shell will and I think
>> you probably will get the right results. Assuming you've actually
>> tested that case and it does work, I think I'm happy with what you have
>> above.
>
> Thanks Phil, I wanted to make sure I was not missing something obvious ;).
>
> Maintainers, please consider v1 of this patch.
>
Just to follow up, this is now in my queue.
Sau!
> Thanks,
> Matthew
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>
next prev parent reply other threads:[~2011-11-08 21:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-04 21:07 [PATCH] Introduce new SERIAL_CONSOLES to add multiple consoles for your MACHINE Matthew McClintock
2011-11-04 21:15 ` Phil Blundell
2011-11-04 21:25 ` [PATCH v2] " Matthew McClintock
2011-11-04 21:34 ` Phil Blundell
2011-11-04 22:12 ` McClintock Matthew-B29882
2011-11-07 23:03 ` McClintock Matthew-B29882
2011-11-08 19:36 ` McClintock Matthew-B29882
2011-11-08 20:47 ` Phil Blundell
2011-11-08 20:50 ` McClintock Matthew-B29882
2011-11-08 21:06 ` Saul Wold [this message]
2011-11-11 1:06 ` Chris Larson
2011-11-10 17:21 ` Saul Wold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EB999E9.30306@linux.intel.com \
--to=sgw@linux.intel.com \
--cc=B29882@freescale.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.