From: "Andreas Färber" <afaerber@suse.de>
To: 陳韋任 <chenwj@iis.sinica.edu.tw>
Cc: qemu-devel@nongnu.org, Juan Quintela <quintela@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 5/6] Makefile.objs: Remove libqemu_common.a target
Date: Tue, 08 Nov 2011 22:49:33 +0100 [thread overview]
Message-ID: <4EB9A3ED.4050801@suse.de> (raw)
In-Reply-To: <20111108170856.GA5179@cs.nctu.edu.tw>
Am 08.11.2011 18:08, schrieb 陳韋任:
>> Have you build this? without this files qemu is not going to work.
>> Perhaps the naming is wrong, and we should change common-obj to
>> something else, but it is still needed to get things working as
>> expected.
>
> I found the line below in Makefile,
>
> $(filter %-softmmu,$(SUBDIR_RULES)): $(trace-obj-y) $(common-obj-y) subdir-libdis
>
> I guess you ran into trouble while building *-softmmu? I think we can
> just remove "libqemu_common.a:" from the comment of common-obj-y and
> leave the rest part alone.
Yes, please. I believe I'm the one to blame, I replaced the .a target
with these lists of .o files to fix the build on OpenSolaris after
constructors was introduced.
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2011-11-08 21:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-08 13:09 [Qemu-devel] [PATCH 5/6] Makefile.objs: Remove libqemu_common.a target Chen Wei-Ren (陳韋任)
2011-11-08 16:34 ` Juan Quintela
2011-11-08 16:57 ` 陳韋任
2011-11-08 17:08 ` 陳韋任
2011-11-08 21:31 ` Juan Quintela
2011-11-08 21:49 ` Andreas Färber [this message]
2011-11-09 2:02 ` 陳韋任
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EB9A3ED.4050801@suse.de \
--to=afaerber@suse.de \
--cc=chenwj@iis.sinica.edu.tw \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.