From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:34812)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1RO7Sn-0006aZ-5F
	for qemu-devel@nongnu.org; Wed, 09 Nov 2011 07:41:10 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1RO7Sl-0006IB-U3
	for qemu-devel@nongnu.org; Wed, 09 Nov 2011 07:41:09 -0500
Received: from mx1.redhat.com ([209.132.183.28]:3957)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1RO7Sl-0006I5-G4
	for qemu-devel@nongnu.org; Wed, 09 Nov 2011 07:41:07 -0500
Message-ID: <4EBA74DC.9030804@redhat.com>
Date: Wed, 09 Nov 2011 14:41:00 +0200
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
References: <1320834838-14623-1-git-send-email-avi@redhat.com>
	<87vcqt7c6g.fsf@linux.vnet.ibm.com>
In-Reply-To: <87vcqt7c6g.fsf@linux.vnet.ibm.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 1.0 v2] configure: fix detection for
 xattr.h on modern distributions
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Cc: qemu-devel@nongnu.org

On 11/09/2011 01:44 PM, Aneesh Kumar K.V wrote:
> On Wed,  9 Nov 2011 12:33:58 +0200, Avi Kivity <avi@redhat.com> wrote:
> > Modern distributions place xattr.h in /usr/include/sys, and fold
> > libattr.so into libc.  They also don't have an ENOATTR.
> > 
> > Make configure detect this, and add a qemu-xattr.h file that
> > directs the #include to the right place.
> > 
> > @@ -3032,6 +3037,9 @@ fi
> >  if test "$attr" = "yes" ; then
> >    echo "CONFIG_ATTR=y" >> $config_host_mak
> >  fi
> > +if test "$libattr" = "yes" ; then
> > +  echo "CONFIG_LIBATTR=y" >> $config_host_mak
> > +fi
>
> Is this needed ? We are adding -lattr to LIBS if needed. What will
> CONFIG_LIBATTR helps us to achieve ?

It's needed to select <sys/xattr.h> vs <attr/xattr.h>.

> >  #include <sys/socket.h>
> >  #include <sys/un.h>
> > -#include <attr/xattr.h>
> > +#include <qemu-xattr.h>
>
> Should this be 
>
> #include "qemu-xattr.h"

Ugh, yes.  Will fix.



-- 
error compiling committee.c: too many arguments to function