From mboxrd@z Thu Jan 1 00:00:00 1970 From: annie li Subject: Re: RE: [PATCH 1/3] Introducing grant table V2 stucture Date: Thu, 10 Nov 2011 00:00:49 +0800 Message-ID: <4EBAA3B1.8010401@oracle.com> References: <4EBA35D3.3020506@oracle.com> <1320826490-29362-1-git-send-email-annie.li@oracle.com> <291EDFCB1E9E224A99088639C4762022B4543AB1BD@LONPMAILBOX01.citrite.net> <20111109144922.GC8410@phenom.dumpdata.com> <291EDFCB1E9E224A99088639C4762022B4543AB204@LONPMAILBOX01.citrite.net> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0664551692==" Return-path: In-Reply-To: <291EDFCB1E9E224A99088639C4762022B4543AB204@LONPMAILBOX01.citrite.net> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Paul Durrant Cc: "kurt.hackel@oracle.com" , "jeremy@goop.org" , "xen-devel@lists.xensource.com" , "linux-kernel@vger.kernel.org" , Konrad Rzeszutek Wilk List-Id: xen-devel@lists.xenproject.org This is a multi-part message in MIME format. --===============0664551692== Content-Type: multipart/alternative; boundary="------------090207080908050300060005" This is a multi-part message in MIME format. --------------090207080908050300060005 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Maybe addr or gnttab_addr? Thanks Annie On 2011-11-9 22:56, Paul Durrant wrote: > I'd be happy with 'addr' or 'opaque' or somesuch if 'raw' is distasteful. > > Paul > > >> -----Original Message----- >> From: Konrad Rzeszutek Wilk [mailto:konrad.wilk@oracle.com] >> Sent: 09 November 2011 14:49 >> To: Paul Durrant >> Cc: annie.li@oracle.com; xen-devel@lists.xensource.com; linux- >> kernel@vger.kernel.org; jeremy@goop.org; kurt.hackel@oracle.com >> Subject: Re: [PATCH 1/3] Introducing grant table V2 stucture >> >> On Wed, Nov 09, 2011 at 11:11:22AM +0000, Paul Durrant wrote: >> >>> Annie, >>> >>> Comments inline below... >>> >>> >>>> -----Original Message----- >>>> >>> [snip] >>> >>>> -static struct grant_entry *shared; >>>> +static union { >>>> + struct grant_entry_v1 *v1; >>>> + void *ring_addr; >>>> +} shared; >>>> + >>>> >>> 'ring_addr' seems like the wrong name here; how about 'raw'? >>> >> Or 'ring'. I asked Annie to change it from 'raw' to something else >> and the first thing that came in my mind was 'ring_addr'. But this >> does not point to a ring, so the 'ring' part is wrong. >> >> Point here is to make it descriptive. 'raw' does not carry meaning >> of _what_ it is suppose to do. >> > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-devel > --------------090207080908050300060005 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Maybe addr or gnttab_addr?

Thanks
Annie

On 2011-11-9 22:56, Paul Durrant wrote: 
I'd be happy with 'addr' or 'opaque' or somesuch if 'raw' is distasteful.

  Paul

  
-----Original Message-----
From: Konrad Rzeszutek Wilk [mailto:konrad.wilk@oracle.com]
Sent: 09 November 2011 14:49
To: Paul Durrant
Cc: annie.li@oracle.com; xen-devel@lists.xensource.com; linux-
kernel@vger.kernel.org; jeremy@goop.org; kurt.hackel@oracle.com
Subject: Re: [PATCH 1/3] Introducing grant table V2 stucture

On Wed, Nov 09, 2011 at 11:11:22AM +0000, Paul Durrant wrote:
    
Annie,

  Comments inline below...

      
-----Original Message-----
        
[snip]
      
-static struct grant_entry *shared;
+static union {
+	struct grant_entry_v1 *v1;
+	void *ring_addr;
+} shared;
+
        
'ring_addr' seems like the wrong name here; how about 'raw'?
      
Or 'ring'. I asked Annie to change it from 'raw' to something else
and the first thing that came in my mind was 'ring_addr'. But this
does not point to a ring, so the 'ring' part is wrong.

Point here is to make it descriptive. 'raw' does not carry meaning
of _what_ it is suppose to do.
    

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
--------------090207080908050300060005-- --===============0664551692== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel --===============0664551692==--