From mboxrd@z Thu Jan 1 00:00:00 1970 From: annie li Subject: Re: RE: [PATCH 3/3] code clean up Date: Thu, 10 Nov 2011 00:10:05 +0800 Message-ID: <4EBAA5DD.3060103@oracle.com> References: <4EBA35D3.3020506@oracle.com> <1320826574-29427-1-git-send-email-annie.li@oracle.com> <291EDFCB1E9E224A99088639C4762022B4543AB1BE@LONPMAILBOX01.citrite.net> <1320841103.955.120.camel@zakaz.uk.xensource.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1054793237==" Return-path: In-Reply-To: <1320841103.955.120.camel@zakaz.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Ian Campbell Cc: "jeremy@goop.org" , "xen-devel@lists.xensource.com" , "konrad.wilk@oracle.com" , "kurt.hackel@oracle.com" , "linux-kernel@vger.kernel.org" , Paul Durrant List-Id: xen-devel@lists.xenproject.org This is a multi-part message in MIME format. --===============1054793237== Content-Type: multipart/alternative; boundary="------------010005040509040707020100" This is a multi-part message in MIME format. --------------010005040509040707020100 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2011-11-9 20:18, Ian Campbell wrote: > On Wed, 2011-11-09 at 11:15 +0000, Paul Durrant wrote: > >> Annie, >> >> Why was this split out as a separate patch? Can it not be folded into patch 2 since the line it re-formats was introduced there? >> > > It is not generally necessary to split string constants in order to meet > the 80 column (soft) limit in Linux code. Some people frown on it > because it breaks grep'ability. > If so, I'd like to revert the change. Thanks Annie > Ian. > > >> Paul >> >> >>> -----Original Message----- >>> From: annie.li@oracle.com [mailto:annie.li@oracle.com] >>> Sent: 09 November 2011 08:16 >>> To: xen-devel@lists.xensource.com; linux-kernel@vger.kernel.org; >>> konrad.wilk@oracle.com; jeremy@goop.org >>> Cc: kurt.hackel@oracle.com; Paul Durrant; annie.li@oracle.com >>> Subject: [PATCH 3/3] code clean up >>> >>> From: Annie Li >>> >>> Signed-off-by: Annie Li >>> --- >>> drivers/xen/grant-table.c | 3 ++- >>> 1 files changed, 2 insertions(+), 1 deletions(-) >>> >>> diff --git a/drivers/xen/grant-table.c b/drivers/xen/grant-table.c >>> index a3294a26..458c00d 100644 >>> --- a/drivers/xen/grant-table.c >>> +++ b/drivers/xen/grant-table.c >>> @@ -708,7 +708,8 @@ static void gnttab_request_version(void) { >>> int rc; >>> struct gnttab_set_version gsv; >>> - const char *str = "we need grant tables version 2, but only >>> version 1 is available\n"; >>> + const char *str = "we need grant tables version 2, " >>> + "but only version 1 is >>> available\n"; >>> >>> gsv.version = 2; >>> rc = HYPERVISOR_grant_table_op(GNTTABOP_set_version, &gsv, >>> 1); >>> -- >>> 1.7.6 >>> >> _______________________________________________ >> Xen-devel mailing list >> Xen-devel@lists.xensource.com >> http://lists.xensource.com/xen-devel >> > > > --------------010005040509040707020100 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit

On 2011-11-9 20:18, Ian Campbell wrote:

On Wed, 2011-11-09 at 11:15 +0000, Paul Durrant wrote:

Annie,

  Why was this split out as a separate patch? Can it not be folded into patch 2 since the line it re-formats was introduced there?


It is not generally necessary to split string constants in order to meet
the 80 column (soft) limit in Linux code. Some people frown on it
because it breaks grep'ability.

If so, I'd like to revert the change.

Thanks
Annie

Ian.

  Paul

-----Original Message-----
From: annie.li@oracle.com [mailto:annie.li@oracle.com]
Sent: 09 November 2011 08:16
To: xen-devel@lists.xensource.com; linux-kernel@vger.kernel.org;
konrad.wilk@oracle.com; jeremy@goop.org
Cc: kurt.hackel@oracle.com; Paul Durrant; annie.li@oracle.com
Subject: [PATCH 3/3] code clean up

From: Annie Li <annie.li@oracle.com>

Signed-off-by: Annie Li <annie.li@oracle.com>
---
 drivers/xen/grant-table.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/drivers/xen/grant-table.c b/drivers/xen/grant-table.c
index a3294a26..458c00d 100644
--- a/drivers/xen/grant-table.c
+++ b/drivers/xen/grant-table.c
@@ -708,7 +708,8 @@ static void gnttab_request_version(void)  {
 	int rc;
 	struct gnttab_set_version gsv;
-	const char *str = "we need grant tables version 2, but only
version 1 is available\n";
+	const char *str = "we need grant tables version 2, "
+					"but only version 1 is
available\n";

 	gsv.version = 2;
 	rc = HYPERVISOR_grant_table_op(GNTTABOP_set_version, &gsv,
1);
--
1.7.6

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

--------------010005040509040707020100-- --===============1054793237== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel --===============1054793237==--