From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:34538)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1ROCin-0006rs-IF
	for qemu-devel@nongnu.org; Wed, 09 Nov 2011 13:18:02 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1ROCim-0008JW-2l
	for qemu-devel@nongnu.org; Wed, 09 Nov 2011 13:18:01 -0500
Received: from v220110690675601.yourvserver.net ([78.47.199.172]:52855)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1ROCil-0008Hw-SD
	for qemu-devel@nongnu.org; Wed, 09 Nov 2011 13:18:00 -0500
Message-ID: <4EBAC398.5060504@weilnetz.de>
Date: Wed, 09 Nov 2011 19:16:56 +0100
From: Stefan Weil <sw@weilnetz.de>
MIME-Version: 1.0
References: <1320839216-19509-1-git-send-email-pbonzini@redhat.com>
In-Reply-To: <1320839216-19509-1-git-send-email-pbonzini@redhat.com>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] win32: remove broken timers
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org

Am 09.11.2011 12:46, schrieb Paolo Bonzini:
> The non-dynticks timer variations are broken, so they can be
> removed.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> qemu-timer.c | 4 +---
> 1 files changed, 1 insertions(+), 3 deletions(-)
>
> diff --git a/qemu-timer.c b/qemu-timer.c
> index f11a28d..cd026c6 100644
> --- a/qemu-timer.c
> +++ b/qemu-timer.c
> @@ -183,10 +183,8 @@ static struct qemu_alarm_timer alarm_timers[] = {
> #endif
> {"unix", unix_start_timer, unix_stop_timer, unix_rearm_timer},
> #else
> - {"mmtimer", mm_start_timer, mm_stop_timer, NULL},
> - {"mmtimer2", mm_start_timer, mm_stop_timer, mm_rearm_timer},
> + {"mmtimer", mm_start_timer, mm_stop_timer, mm_rearm_timer},
> {"dynticks", win32_start_timer, win32_stop_timer, win32_rearm_timer},
> - {"win32", win32_start_timer, win32_stop_timer, NULL},
> #endif
> {NULL, }
> };

Reviewed-by: Stefan Weil <sw@weilnetz.de>

This patch is needed for QEMU 1.0 because it fixes a fatal assertion
with the default timer for QEMU on w32 hosts.

Regards,
Stefan Weil