From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:59764)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1ROCoy-00020R-7D
	for qemu-devel@nongnu.org; Wed, 09 Nov 2011 13:24:24 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1ROCox-0001R1-BG
	for qemu-devel@nongnu.org; Wed, 09 Nov 2011 13:24:24 -0500
Received: from v220110690675601.yourvserver.net ([78.47.199.172]:33339)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1ROCox-0001Ql-57
	for qemu-devel@nongnu.org; Wed, 09 Nov 2011 13:24:23 -0500
Message-ID: <4EBAC52C.2030206@weilnetz.de>
Date: Wed, 09 Nov 2011 19:23:40 +0100
From: Stefan Weil <sw@weilnetz.de>
MIME-Version: 1.0
References: <1320834838-14623-1-git-send-email-avi@redhat.com>
In-Reply-To: <1320834838-14623-1-git-send-email-avi@redhat.com>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 1.0 v2] configure: fix detection for
 xattr.h on	modern distributions
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Avi Kivity <avi@redhat.com>
Cc: qemu-devel@nongnu.org, "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>

Am 09.11.2011 11:33, schrieb Avi Kivity:
> Modern distributions place xattr.h in /usr/include/sys, and fold
> libattr.so into libc.  They also don't have an ENOATTR.
>
> Make configure detect this, and add a qemu-xattr.h file that
> directs the #include to the right place.
>
> Signed-off-by: Avi Kivity<avi@redhat.com>
> ---
>
> v2: try for libc first, libattr second
>    
[...]
> +
> +/*
> + * Modern distributions (e.g. Fedora 15, have no libattr.so, place attr.h
> + * in /usr/include/sys, and don't have ENOATTR.
>    

There is a ')' missing, so I add it here: :-)

Whoever commits the patch can add it, too, so no v3 is needed for this 
patch.

> + */
> +
> +#include "config-host.h"
> +
> +#ifdef CONFIG_LIBATTR
> +#  include<attr/xattr.h>
> +#else
> +#  define ENOATTR ENODATA
> +#  include<sys/xattr.h>
> +#endif
> +
> +#endif
>