From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:56157)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1ROE4Y-0002we-NU
	for qemu-devel@nongnu.org; Wed, 09 Nov 2011 14:44:35 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1ROE4X-0000Ye-Mr
	for qemu-devel@nongnu.org; Wed, 09 Nov 2011 14:44:34 -0500
Received: from mail-gy0-f173.google.com ([209.85.160.173]:61802)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1ROE4X-0000YW-KJ
	for qemu-devel@nongnu.org; Wed, 09 Nov 2011 14:44:33 -0500
Received: by gyb11 with SMTP id 11so2345502gyb.4
	for <qemu-devel@nongnu.org>; Wed, 09 Nov 2011 11:44:32 -0800 (PST)
Message-ID: <4EBAD81C.7010603@codemonkey.ws>
Date: Wed, 09 Nov 2011 13:44:28 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <1320746280-31710-1-git-send-email-armbru@redhat.com>
In-Reply-To: <1320746280-31710-1-git-send-email-armbru@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] Clean up assertion in
	get_boot_devices_list()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org, gleb@redhat.com

On 11/08/2011 03:58 AM, Markus Armbruster wrote:
> g_strdup() can't fail, remove assertion.  Assert its argument can't be
> null, because that's not obvious (add_boot_device_path() ensures it).
>
> Signed-off-by: Markus Armbruster<armbru@redhat.com>

Applied.  Thanks.

Regards,

Anthony Liguori

> ---
>   vl.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/vl.c b/vl.c
> index 641629b..f169aac 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -915,8 +915,8 @@ char *get_boot_devices_list(uint32_t *size)
>           } else if (devpath) {
>               bootpath = devpath;
>           } else {
> +            assert(i->suffix);
>               bootpath = g_strdup(i->suffix);
> -            assert(bootpath);
>           }
>
>           if (total) {