From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:54251) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ROInb-0008F5-9W for qemu-devel@nongnu.org; Wed, 09 Nov 2011 19:47:24 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ROInZ-0002xK-SV for qemu-devel@nongnu.org; Wed, 09 Nov 2011 19:47:23 -0500 Received: from mail-yx0-f173.google.com ([209.85.213.173]:49399) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ROInZ-0002wt-Q6 for qemu-devel@nongnu.org; Wed, 09 Nov 2011 19:47:21 -0500 Received: by yenr8 with SMTP id r8so1485747yen.4 for ; Wed, 09 Nov 2011 16:47:21 -0800 (PST) Message-ID: <4EBB1F16.7070404@codemonkey.ws> Date: Wed, 09 Nov 2011 18:47:18 -0600 From: Anthony Liguori MIME-Version: 1.0 References: <1320802728-21841-1-git-send-email-agraf@suse.de> <4EBA16A1.9090703@weilnetz.de> <4EBA558A.20707@suse.de> <4EBABF07.6090307@codemonkey.ws> <4EBABFE1.4070200@suse.de> <4EBB0F0E.4000908@codemonkey.ws> <05624566-E095-4870-A836-B8D836BB5567@suse.de> In-Reply-To: <05624566-E095-4870-A836-B8D836BB5567@suse.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] pci-stub: fix compile breakage with qmp List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: "qemu-devel@nongnu.org" , Stefan Weil , =?ISO-8859-1?Q?Andreas_F=E4rber?= , Luiz Capitulino On 11/09/2011 05:44 PM, Alexander Graf wrote: > > On 10.11.2011, at 00:38, Anthony Liguori wrote: > >> On 11/09/2011 05:12 PM, Alexander Graf wrote: >>> >>>> We have been using it that way in the past and I am not aware of a patch >>>> that removed ancient cleanups, so it's good practice to keep it working >>>> that way. >>>> >>>> When I do a git pull I don't know whether or what it may bring. Always >>>> doing make clean just-in-case is simply unproductive. >>> >>> I agree. After a git pull the worst case I want to see is that I need to do make defconfig clean. Anything that doesn't clean up this way leaves my build in a broken state, meaning it's a bug to me. >> >> Sorry, but there's no way around this. This doesn't happen often and emails are almost always sent ahead of time. >> >> It's impossible to test something like this because by definition, the code no longer lives in the tree. > > If we don't want to fix it, then we should remove the object directories for the build targets on git updates. I suspect the real problem you're having is that you are building within the src directory instead of a separate object directory. But at any rate, if you do a 'make clean' before a git fetch/merge, you'll also be fine. Regards, Anthony Liguori > > > Alex > >