From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:47768) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ROIrq-0001um-7M for qemu-devel@nongnu.org; Wed, 09 Nov 2011 19:51:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ROIro-00048K-MQ for qemu-devel@nongnu.org; Wed, 09 Nov 2011 19:51:46 -0500 Received: from mail-iy0-f173.google.com ([209.85.210.173]:41706) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ROIro-000489-JP for qemu-devel@nongnu.org; Wed, 09 Nov 2011 19:51:44 -0500 Received: by iakk32 with SMTP id k32so2649965iak.4 for ; Wed, 09 Nov 2011 16:51:43 -0800 (PST) Message-ID: <4EBB201C.70701@codemonkey.ws> Date: Wed, 09 Nov 2011 18:51:40 -0600 From: Anthony Liguori MIME-Version: 1.0 References: <1320802728-21841-1-git-send-email-agraf@suse.de> <4EBA16A1.9090703@weilnetz.de> <4EBA558A.20707@suse.de> <20111109104751.3b5a028d@doriath> In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH] pci-stub: fix compile breakage with qmp List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: qemu-devel@nongnu.org, Stefan Weil , =?windows-1252?Q?Andreas_F=E4rber?= , Luiz Capitulino On 11/09/2011 05:45 PM, Alexander Graf wrote: > > On 09.11.2011, at 13:47, Luiz Capitulino wrote: > >> On Wed, 09 Nov 2011 11:27:22 +0100 >> Andreas Färber wrote: >> >>> Am 09.11.2011 06:58, schrieb Stefan Weil: >>>> Am 09.11.2011 02:38, schrieb Alexander Graf: >>>>> Commit 79627472db3 introduced breakage in compiling the s390x-softmmu >>>>> target. Instead of compiling, it just throws a lot of errors: >>>>> >>>>> In file included from /dev/shm/qemu/hw/pci-stub.c:24: >>>>> ./qmp-commands.h:3: error: expected identifier or ‘(’ before ‘{’ token >>>>> [...] >>>>> >>>>> This is because we have two files called qmp-commands.h. One resides in >>>>> the root directory of the source tree. The other one resides in the >>>>> target >>>>> build directory. >>>>> >>>>> Because pci-stub is not built in libhw, pci-stub.c seems to pick up the >>>>> qmp-commands.h file from the target build directory which contains only >>>>> definitions of qmp commands, not the function stubs. >>>>> >>>>> This patch at least fixes this breakage for me, allowing me to compile >>>>> s390x-softmmu again. >>>>> >>>>> CC: Luiz Capitulino >>>>> Signed-off-by: Alexander Graf >>>>> --- >>>>> hw/pci-stub.c | 2 +- >>>>> 1 files changed, 1 insertions(+), 1 deletions(-) >>>>> >>>>> diff --git a/hw/pci-stub.c b/hw/pci-stub.c >>>>> index 636171c..ab9789c 100644 >>>>> --- a/hw/pci-stub.c >>>>> +++ b/hw/pci-stub.c >>>>> @@ -21,7 +21,7 @@ >>>>> #include "sysemu.h" >>>>> #include "monitor.h" >>>>> #include "pci.h" >>>>> -#include "qmp-commands.h" >>>>> +#include "../qmp-commands.h" >>>>> >>>>> PciInfoList *qmp_query_pci(Error **errp) >>>>> { >>>> >>>> No. Simply remove */qmp-commands.h. They are relicts from previous builds. >>> >>> If make clean didn't help, please patch that instead then. >> >> So, did it fix the problem for you Alex? > > Yup :). However, if I run into this other users / developers will too. That's why I sent this note: http://mid.gmane.org/4E930612.2090104@codemonkey.ws So that everyone was aware of this. If you didn't read the note because you don't read every message on qemu-devel religiously (but I mean, doesn't everyone), then you should at least filter FYI or ANNOUNCES to a special folders. I usually try to use an appropriate prefix when it's something that people need to look at. You could also just filter any mail from me because every email I send is certainly worth reading ;-) Regards, Anthony Liguori > > > Alex > >