From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:34600)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanb@linux.vnet.ibm.com>) id 1ROJle-0007yQ-K0
	for qemu-devel@nongnu.org; Wed, 09 Nov 2011 20:49:27 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanb@linux.vnet.ibm.com>) id 1ROJld-00024n-Jl
	for qemu-devel@nongnu.org; Wed, 09 Nov 2011 20:49:26 -0500
Received: from e6.ny.us.ibm.com ([32.97.182.146]:50818)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanb@linux.vnet.ibm.com>) id 1ROJld-00024j-DI
	for qemu-devel@nongnu.org; Wed, 09 Nov 2011 20:49:25 -0500
Received: from /spool/local
	by e6.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only!
	Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <stefanb@linux.vnet.ibm.com>;
	Wed, 9 Nov 2011 20:49:23 -0500
Received: from d01av04.pok.ibm.com (d01av04.pok.ibm.com [9.56.224.64])
	by d01relay04.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id
	pAA1mhtt259376
	for <qemu-devel@nongnu.org>; Wed, 9 Nov 2011 20:48:45 -0500
Received: from d01av04.pok.ibm.com (loopback [127.0.0.1])
	by d01av04.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id
	pAA1mhHV014189
	for <qemu-devel@nongnu.org>; Wed, 9 Nov 2011 20:48:43 -0500
Message-ID: <4EBB2D75.5050601@linux.vnet.ibm.com>
Date: Wed, 09 Nov 2011 20:48:37 -0500
From: Stefan Berger <stefanb@linux.vnet.ibm.com>
MIME-Version: 1.0
References: <1320870541-4571-1-git-send-email-quintela@redhat.com>
In-Reply-To: <1320870541-4571-1-git-send-email-quintela@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] migration: fix detached migration with fd
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Juan Quintela <quintela@redhat.com>
Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org

On 11/09/2011 03:29 PM, Juan Quintela wrote:
> Migration with fd uses s->mon to pass the fd.  But we only assign the
> s->mon for !detached migration.  Fix it.  Once there add a comment
> indicating that s->mon has two uses.

I had encounter the NULL pointer problem when suspending using 'virsh 
save...'. Now with your patch it unfortunately doesn't terminate, i.e., 
qemu is still running while the file has been written completely.

    Stefan