All of lore.kernel.org
 help / color / mirror / Atom feed
From: ANNIE LI <annie.li@oracle.com>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: "jeremy@goop.org" <jeremy@goop.org>,
	"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	"kurt.hackel@oracle.com" <kurt.hackel@oracle.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Paul Durrant <Paul.Durrant@citrix.com>
Subject: Re: [Xen-devel] RE: [PATCH 1/3] Introducing grant table V2 stucture
Date: Thu, 10 Nov 2011 09:56:56 +0800	[thread overview]
Message-ID: <4EBB2F68.8070609@oracle.com> (raw)
In-Reply-To: <1320855724.955.183.camel@zakaz.uk.xensource.com>



On 2011-11-10 0:22, Ian Campbell wrote:
> IMHO the gnttab_ bit belongs in either (or both) the struct name or the
> variable names referencing the struct, rather than the fields
> themselves. It should be obvious from the context that this member is
> something to do with gnttab. e.g. I think gnttab_shared->addr would be
> fine, as would shared->addr in the context of gnttab.c etc.
Right.
Thanks you all for the review, I will improve patches based on those 
suggestions and resend them.

Thanks
Annie

  reply	other threads:[~2011-11-10  1:57 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-09  8:12 patches of upstreaming grant table version 2 ANNIE LI
2011-11-09  8:14 ` [PATCH 1/3] Introducing grant table V2 stucture annie.li
2011-11-09 11:11   ` Paul Durrant
2011-11-09 11:11     ` Paul Durrant
2011-11-09 14:49     ` Konrad Rzeszutek Wilk
2011-11-09 14:56       ` Paul Durrant
2011-11-09 16:00         ` annie li
2011-11-09 16:22           ` [Xen-devel] " Ian Campbell
2011-11-10  1:56             ` ANNIE LI [this message]
2011-11-09 16:08     ` annie li
2011-11-09 16:14       ` Paul Durrant
2011-11-10  1:50         ` [Xen-devel] " ANNIE LI
2011-11-10  1:50           ` ANNIE LI
2011-11-09 13:28   ` [Xen-devel] " Ian Campbell
2011-11-09 16:19     ` annie li
2011-11-09  8:15 ` [PATCH 2/3] Grant tables v2 implementation annie.li
2011-11-09 13:32   ` [Xen-devel] " Ian Campbell
2011-11-09 16:30     ` annie li
2011-11-09  8:16 ` [PATCH 3/3] code clean up annie.li
2011-11-09 11:15   ` Paul Durrant
2011-11-09 11:15     ` Paul Durrant
2011-11-09 12:18     ` [Xen-devel] " Ian Campbell
2011-11-09 16:10       ` annie li
2011-11-09  9:05 ` [Xen-devel] patches of upstreaming grant table version 2 ANNIE LI

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EBB2F68.8070609@oracle.com \
    --to=annie.li@oracle.com \
    --cc=Ian.Campbell@citrix.com \
    --cc=Paul.Durrant@citrix.com \
    --cc=jeremy@goop.org \
    --cc=konrad.wilk@oracle.com \
    --cc=kurt.hackel@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.