From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:54998)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <andreas.faerber@web.de>) id 1ROS4u-00033z-Ut
	for qemu-devel@nongnu.org; Thu, 10 Nov 2011 05:41:53 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <andreas.faerber@web.de>) id 1ROS4t-0000vd-SI
	for qemu-devel@nongnu.org; Thu, 10 Nov 2011 05:41:52 -0500
Received: from fmmailgate05.web.de ([217.72.192.243]:46187)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <andreas.faerber@web.de>) id 1ROS4t-0000vZ-KA
	for qemu-devel@nongnu.org; Thu, 10 Nov 2011 05:41:51 -0500
Received: from moweb002.kundenserver.de (moweb002.kundenserver.de
	[172.19.20.108])
	by fmmailgate05.web.de (Postfix) with ESMTP id 86274677B8F5
	for <qemu-devel@nongnu.org>; Thu, 10 Nov 2011 11:41:50 +0100 (CET)
Message-ID: <4EBBAA67.5080305@web.de>
Date: Thu, 10 Nov 2011 11:41:43 +0100
From: =?ISO-8859-15?Q?Andreas_F=E4rber?= <andreas.faerber@web.de>
MIME-Version: 1.0
References: <1320864854-19470-1-git-send-email-pavel.borzenkov@gmail.com>
In-Reply-To: <1320864854-19470-1-git-send-email-pavel.borzenkov@gmail.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 1.0] configure: add '--disable-cocoa' switch
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Pavel Borzenkov <pavel.borzenkov@gmail.com>
Cc: qemu-devel@nongnu.org

Am 09.11.2011 19:54, schrieb Pavel Borzenkov:
> When SDL support is disabled, there is no way to build QEMU without
> Cocoa support on MacOS X. This patch adds '--disable-cocoa' switch and
> allows to build QEMU without both SDL and Cocoa frontends.
> 
> Signed-off-by: Pavel Borzenkov <pavel.borzenkov@gmail.com>

This is a new feature and therefore too late for 1.0. Only bugfixes now.

I remember there was a similar patch once but some issue with it kept us
from applying it - something unrelated to the frontend was influenced by
it I think... block layer?

> ---
>  configure |   11 ++++++-----
>  1 files changed, 6 insertions(+), 5 deletions(-)
> 
> diff --git a/configure b/configure
> index 9e5da44..ba3a830 100755
> --- a/configure
> +++ b/configure

> @@ -1424,10 +1429,6 @@ EOF
>    if compile_prog "$sdl_cflags" "$sdl_libs" ; then
>      if test "$_sdlversion" -lt 121 ; then
>        sdl_too_old=yes
> -    else
> -      if test "$cocoa" = "no" ; then
> -        sdl=yes
> -      fi

Without looking at the context, this hunk looks weird. You sure you're
not breaking the SDL default for other platforms?

>      fi
>  
>      # static link with sdl ? (note: sdl.pc's --static --libs is broken)


Anyway, I would much more appreciate a bugfix or suggestion how to make
Cocoa build than to disable it altogether (and then only based on a
configure option).

Andreas