All of lore.kernel.org
 help / color / mirror / Atom feed
From: Aneesh V <aneesh@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] Build u-boot.imx by default when board uses it
Date: Fri, 11 Nov 2011 09:09:06 +0530	[thread overview]
Message-ID: <4EBC98DA.3070706@ti.com> (raw)
In-Reply-To: <201111102051.46801.vapier@gentoo.org>

On Friday 11 November 2011 07:21 AM, Mike Frysinger wrote:
> On Thursday 10 November 2011 18:45:30 Lo?c Minier wrote:
>> On Thu, Nov 10, 2011, Mike Frysinger wrote:
>>>> +ifneq ($(CONFIG_IMX_CONFIG),)
>>>> +ALL-y += $(obj)u-boot.imx
>>>> +endif
>>>
>>> why won't this work:
>>> ALL-$(CONFIG_IMX_CONFIG) += $(obj)u-boot.mix
>>> that was the point of naming it "ALL-y" in the first place ...
>>
>>   That's what I tried at first, but CONFIG_IMX_CONFIG is actually the
>>   name of the config file to pass to mkimage; same for u-boot.kwb.
>>
>>   CONFIG_IMX_CONFIG is set in boards.cfg.
>
> ugly undocumented CONFIG's are awesome
>
> this really should be in a subdir rather than the top level.  we want to keep
> arch/soc-specific cruft out of the top level Makefile if possible.  isn't there
> a sub-config.mk somewhere you could add the line unconditionally ?

This is what I have done for u-boot.img for OMAP4.

arch/arm/cpu/armv7/omap4/config.mk has this:

ifdef CONFIG_SPL_BUILD
ALL-y	+= $(OBJTREE)/MLO
else
ALL-y	+= $(obj)u-boot.img
endif

However, this may have to be duplicated in many such config.mk files.

br,
Aneesh

  reply	other threads:[~2011-11-11  3:39 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-10 13:49 [U-Boot] Improve default "make" targets (ALL-y) Loïc Minier
2011-11-10 13:49 ` [U-Boot] [PATCH 1/2] Build u-boot.imx by default when board uses it Loïc Minier
2011-11-10 15:35   ` Stefano Babic
2011-11-10 23:24   ` Mike Frysinger
2011-11-10 23:45     ` Loïc Minier
2011-11-11  1:51       ` Mike Frysinger
2011-11-11  3:39         ` Aneesh V [this message]
2011-11-11 13:31           ` Loïc Minier
2011-11-11 13:35         ` Loïc Minier
2011-11-11 16:43           ` Mike Frysinger
2011-11-17  7:07           ` Stefano Babic
2011-11-17  7:37           ` Wolfgang Denk
2011-11-11  2:29       ` Daniel Schwierzeck
2011-11-11 13:26         ` Loïc Minier
2012-04-02 17:03           ` Stefano Babic
2012-04-02 18:25             ` Mike Frysinger
2012-04-03 14:22               ` Stefano Babic
2011-11-10 13:49 ` [U-Boot] [PATCH 2/2] Build u-boot.kwb " Loïc Minier
2011-11-10 14:54 ` [U-Boot] Improve default "make" targets (ALL-y) Tom Rini
2011-11-11 13:41   ` Loïc Minier
2011-11-11 16:41     ` Mike Frysinger
2011-11-11 21:01       ` Loïc Minier
2011-11-11 22:50         ` Mike Frysinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EBC98DA.3070706@ti.com \
    --to=aneesh@ti.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.