From: Caspar Zhang <caspar@casparzhang.com>
To: Eryu Guan <eguan@redhat.com>
Cc: ltp-list@lists.sourceforge.net
Subject: Re: [LTP] [PATCH] syscall/dup03: Close all open files in cleanup
Date: Fri, 11 Nov 2011 12:56:11 +0800 [thread overview]
Message-ID: <4EBCAAEB.6010004@casparzhang.com> (raw)
In-Reply-To: <1320987154-28844-1-git-send-email-eguan@redhat.com>
On 11/11/2011 12:52 PM, Eryu Guan wrote:
>
> The 'silly rename' mechanism of NFS creates temporary file .nfsXXX in
> NFS mount. The cleanup() in dup03.c doesn't close all open files and
> leaves .nfsXXX file in the testing directory. Then rmdir(2) complains
> about "Directory not empty".
>
> dup03 1 TPASS : dup failed as expected with EMFILE
> dup03 0 TWARN : tst_rmdir: rmobj(/mnt/nfs/dupxesX9v) failed: remove(/mnt/nfs/dupxesX9v) failed; errno=39: Directory not empty
>
> So close all open files in cleanup().
>
> Signed-off-by: Eryu Guan <eguan@redhat.com>
Acked-by: Caspar Zhang <caspar@casparzhang.com>
------------------------------------------------------------------------------
RSA(R) Conference 2012
Save $700 by Nov 18
Register now
http://p.sf.net/sfu/rsa-sfdev2dev1
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
next prev parent reply other threads:[~2011-11-11 5:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-11 4:52 [LTP] [PATCH] syscall/dup03: Close all open files in cleanup Eryu Guan
2011-11-11 4:56 ` Caspar Zhang [this message]
2011-11-11 14:33 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EBCAAEB.6010004@casparzhang.com \
--to=caspar@casparzhang.com \
--cc=eguan@redhat.com \
--cc=ltp-list@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.