From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:53314) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ROrJo-0003nz-BY for qemu-devel@nongnu.org; Fri, 11 Nov 2011 08:39:01 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ROrJi-0006zv-Sz for qemu-devel@nongnu.org; Fri, 11 Nov 2011 08:38:56 -0500 Received: from mx1.redhat.com ([209.132.183.28]:28116) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ROrJi-0006zq-Kl for qemu-devel@nongnu.org; Fri, 11 Nov 2011 08:38:50 -0500 Message-ID: <4EBD2564.6080105@redhat.com> Date: Fri, 11 Nov 2011 14:38:44 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1320940872-4940-1-git-send-email-pbonzini@redhat.com> <1320940872-4940-2-git-send-email-pbonzini@redhat.com> <4EBD24F0.9090105@redhat.com> In-Reply-To: <4EBD24F0.9090105@redhat.com> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/5] atapi: kill MODE SENSE(6), fix MODE SENSE(10) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-devel@nongnu.org, scdbackup@gmx.net, kraxel@redhat.com On 11/11/2011 02:36 PM, Kevin Wolf wrote: >> > @@ -717,11 +712,10 @@ static void cmd_mode_sense(IDEState *s, uint8_t *buf) >> > buf[12] = 0x00; >> > buf[13] = 0x00; >> > buf[14] = 0x00; >> > - buf[15] = 0x00; > Why did you drop this? It still seems to be part of the buffer. Ouch. No idea. Actually, I think it's best if these patches wait until Thomas can give a shot at testing them. If that means missing 1.0, so be it. Paolo