From: "Vladimir 'φ-coder/phcoder' Serbinenko" <phcoder@gmail.com>
To: grub-devel@gnu.org
Subject: Re: [PATCH] Enable install of grub2 in PReP partition
Date: Fri, 11 Nov 2011 16:11:17 +0100 [thread overview]
Message-ID: <4EBD3B15.1040300@gmail.com> (raw)
In-Reply-To: <4EBD2AE0.7020200@linux.vnet.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 464 bytes --]
On 11.11.2011 15:02, Paulo de Rezende Pinatti wrote:
> + if (dev->disk->partition == NULL)
> + {
> + grub_util_info ("no partition map found for %s", dev->disk->name);
> + }
> +
> + if (strcmp(dev->disk->partition->partmap->name, "msdos") == 0)
This is wrong, you check for the pointer being non-NULL, issue a warning
and then happily dereference it regardless.
--
Regards
Vladimir 'φ-coder/phcoder' Serbinenko
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 294 bytes --]
prev parent reply other threads:[~2011-11-11 15:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-11 14:02 [PATCH] Enable install of grub2 in PReP partition Paulo de Rezende Pinatti
2011-11-11 15:11 ` Vladimir 'φ-coder/phcoder' Serbinenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EBD3B15.1040300@gmail.com \
--to=phcoder@gmail.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.