diff for duplicates of <4EBD3ED8.9010005@suse.de> diff --git a/a/1.txt b/N1/1.txt index fa2f296..48dafea 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -19,15 +19,17 @@ On 11/11/2011 04:24 PM, Thomas Meyer wrote: >>> --- a/arch/powerpc/kvm/e500_tlb.c 2011-11-07 19:37:27.329638682 +0100 >>> +++ b/arch/powerpc/kvm/e500_tlb.c 2011-11-08 09:18:39.955928218 +0100 >>> @@ -1026,11 +1026,11 @@ int kvmppc_e500_tlb_init(struct kvmppc_v ->>> if (vcpu_e500->gtlb_arch[1] = NULL) +>>> if (vcpu_e500->gtlb_arch[1] == NULL) >>> goto err_out_guest0; >>> >>> - vcpu_e500->gtlb_priv[0] = (struct tlbe_priv *) ->>> + vcpu_e500->gtlb_priv[0] >>> kzalloc(sizeof(struct tlbe_priv) * KVM_E500_TLB0_SIZE, GFP_KERNEL); ->>> if (vcpu_e500->gtlb_priv[0] = NULL) +>>> + vcpu_e500->gtlb_priv[0] = +>>> kzalloc(sizeof(struct tlbe_priv) * KVM_E500_TLB0_SIZE, GFP_KERNEL); +>>> if (vcpu_e500->gtlb_priv[0] == NULL) >>> goto err_out_guest1; >>> - vcpu_e500->gtlb_priv[1] = (struct tlbe_priv *) ->>> + vcpu_e500->gtlb_priv[1] >>> kzalloc(sizeof(struct tlbe_priv) * KVM_E500_TLB1_SIZE, GFP_KERNEL); +>>> + vcpu_e500->gtlb_priv[1] = +>>> kzalloc(sizeof(struct tlbe_priv) * KVM_E500_TLB1_SIZE, GFP_KERNEL); >> Sorry, I can't seem to find that code anywhere. I suppose you're using >> an old git checkout? > No, I'm at 3.2-rc1: diff --git a/a/content_digest b/N1/content_digest index 0a8062f..0dd2a2e 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -2,8 +2,8 @@ "ref\04EBD2BB4.3030804@suse.de\0" "ref\01321025097.20155.118.camel@localhost.localdomain\0" "From\0Alexander Graf <agraf@suse.de>\0" - "Subject\0Re: [PATCH] KVM: PPC: e500: Casting (void *) value returned by kmalloc\0" - "Date\0Fri, 11 Nov 2011 15:27:20 +0000\0" + "Subject\0Re: [PATCH] KVM: PPC: e500: Casting (void *) value returned by kmalloc is useless\0" + "Date\0Fri, 11 Nov 2011 16:27:20 +0100\0" "To\0Thomas Meyer <thomas@m3y3r.de>\0" "Cc\0Avi Kivity <avi@redhat.com>" kvm@vger.kernel.org @@ -32,15 +32,17 @@ ">>> --- a/arch/powerpc/kvm/e500_tlb.c 2011-11-07 19:37:27.329638682 +0100\n" ">>> +++ b/arch/powerpc/kvm/e500_tlb.c 2011-11-08 09:18:39.955928218 +0100\n" ">>> @@ -1026,11 +1026,11 @@ int kvmppc_e500_tlb_init(struct kvmppc_v\n" - ">>> \tif (vcpu_e500->gtlb_arch[1] = NULL)\n" + ">>> \tif (vcpu_e500->gtlb_arch[1] == NULL)\n" ">>> \t\tgoto err_out_guest0;\n" ">>>\n" ">>> -\tvcpu_e500->gtlb_priv[0] = (struct tlbe_priv *)\n" - ">>> +\tvcpu_e500->gtlb_priv[0] >>> \t\tkzalloc(sizeof(struct tlbe_priv) * KVM_E500_TLB0_SIZE, GFP_KERNEL);\n" - ">>> \tif (vcpu_e500->gtlb_priv[0] = NULL)\n" + ">>> +\tvcpu_e500->gtlb_priv[0] =\n" + ">>> \t\tkzalloc(sizeof(struct tlbe_priv) * KVM_E500_TLB0_SIZE, GFP_KERNEL);\n" + ">>> \tif (vcpu_e500->gtlb_priv[0] == NULL)\n" ">>> \t\tgoto err_out_guest1;\n" ">>> -\tvcpu_e500->gtlb_priv[1] = (struct tlbe_priv *)\n" - ">>> +\tvcpu_e500->gtlb_priv[1] >>> \t\tkzalloc(sizeof(struct tlbe_priv) * KVM_E500_TLB1_SIZE, GFP_KERNEL);\n" + ">>> +\tvcpu_e500->gtlb_priv[1] =\n" + ">>> \t\tkzalloc(sizeof(struct tlbe_priv) * KVM_E500_TLB1_SIZE, GFP_KERNEL);\n" ">> Sorry, I can't seem to find that code anywhere. I suppose you're using\n" ">> an old git checkout?\n" "> No, I'm at 3.2-rc1:\n" @@ -55,4 +57,4 @@ "\n" Alex -24d4487e8bc02cce13a5bfb667e3222cd45218762922e108ab0f8b23d9550232 +f1c72011b3eb08647b9f89529adc8d535bbe7e0745f094f6aaac0f6ef1649ab3
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.