From: Tabi Timur-B04825 <B04825@freescale.com>
To: linux-fbdev@vger.kernel.org
Subject: Re: [RFC] drivers/video: fsl-diu-fb: combine several allocated
Date: Fri, 11 Nov 2011 16:41:25 +0000 [thread overview]
Message-ID: <4EBD5033.2020603@freescale.com> (raw)
In-Reply-To: <1320793445-29562-1-git-send-email-timur@freescale.com>
Florian Tobias Schandinat wrote:
> The idea to merge multiple DMA objects sounds good. But I think you might want
> to have a look at what you put in the DMA area. I think it would be better and
> cleaner to put things that should be never accessed by the device, like
> fsl_diu_info, irq, reg_lock and so on, in a separate structure.
Hmmm... you have a valid point, but I'm not keen on the idea of having two
memory blocks. I was even hoping to put mfb_info objects in fsl_diu_info,
but framebuffer_alloc() won't let me.
>> Documentation for some affected data structures and variables is added.
>
> You could do this in an separate patch as it's independent of your idea to merge
> the DMA objects. Well, I do not care very much in this case.
I can split it out. It will give me the chance to add even more
documentation.
--
Timur Tabi
Linux kernel developer at Freescale
prev parent reply other threads:[~2011-11-11 16:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-08 23:04 [RFC] drivers/video: fsl-diu-fb: combine several allocated buffers into one Timur Tabi
2011-11-11 16:15 ` [RFC] drivers/video: fsl-diu-fb: combine several allocated buffers Florian Tobias Schandinat
2011-11-11 16:41 ` Tabi Timur-B04825 [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EBD5033.2020603@freescale.com \
--to=b04825@freescale.com \
--cc=linux-fbdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.