All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anthony Liguori <anthony@codemonkey.ws>
To: Pavel Borzenkov <pavel.borzenkov@gmail.com>
Cc: andreas.faerber@web.de, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1.0] configure: add '--disable-cocoa' switch
Date: Fri, 11 Nov 2011 12:49:35 -0600	[thread overview]
Message-ID: <4EBD6E3F.7020209@codemonkey.ws> (raw)
In-Reply-To: <1320864854-19470-1-git-send-email-pavel.borzenkov@gmail.com>

On 11/09/2011 12:54 PM, Pavel Borzenkov wrote:
> When SDL support is disabled, there is no way to build QEMU without
> Cocoa support on MacOS X. This patch adds '--disable-cocoa' switch and
> allows to build QEMU without both SDL and Cocoa frontends.
>
> Signed-off-by: Pavel Borzenkov<pavel.borzenkov@gmail.com>

This breaks SDL probing on Linux.

> ---
>   configure |   11 ++++++-----
>   1 files changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/configure b/configure
> index 9e5da44..ba3a830 100755
> --- a/configure
> +++ b/configure
> @@ -669,6 +669,8 @@ for opt do
>     ;;
>     --enable-profiler) profiler="yes"
>     ;;
> +  --disable-cocoa) cocoa="no"
> +  ;;
>     --enable-cocoa)
>         cocoa="yes" ;
>         sdl="no" ;
> @@ -979,7 +981,10 @@ echo "  --disable-sdl            disable SDL"
>   echo "  --enable-sdl             enable SDL"
>   echo "  --disable-vnc            disable VNC"
>   echo "  --enable-vnc             enable VNC"
> -echo "  --enable-cocoa           enable COCOA (Mac OS X only)"
> +if test "$darwin" = "yes" ; then
> +    echo "  --disable-cocoa          disable COCOA"
> +    echo "  --enable-cocoa           enable COCOA"
> +fi
>   echo "  --audio-drv-list=LIST    set audio drivers list:"
>   echo "                           Available drivers: $audio_possible_drivers"
>   echo "  --audio-card-list=LIST   set list of emulated audio cards [$audio_card_list]"
> @@ -1424,10 +1429,6 @@ EOF
>     if compile_prog "$sdl_cflags" "$sdl_libs" ; then
>       if test "$_sdlversion" -lt 121 ; then
>         sdl_too_old=yes
> -    else
> -      if test "$cocoa" = "no" ; then
> -        sdl=yes
> -      fi

This is what normally enables SDL.

Regards,

Anthony Liguori
>       fi
>
>       # static link with sdl ? (note: sdl.pc's --static --libs is broken)

      parent reply	other threads:[~2011-11-11 18:49 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-09 18:54 [Qemu-devel] [PATCH 1.0] configure: add '--disable-cocoa' switch Pavel Borzenkov
2011-11-10 10:41 ` Andreas Färber
2011-11-10 10:44   ` Peter Maydell
2011-11-10 11:54     ` Pavel Borzenkov
2011-11-10 12:23       ` Peter Maydell
2011-11-10 12:02   ` Pavel Borzenkov
2011-11-11 18:49 ` Anthony Liguori [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EBD6E3F.7020209@codemonkey.ws \
    --to=anthony@codemonkey.ws \
    --cc=andreas.faerber@web.de \
    --cc=pavel.borzenkov@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.