From mboxrd@z Thu Jan 1 00:00:00 1970 From: Florian Tobias Schandinat Date: Sat, 12 Nov 2011 00:21:43 +0000 Subject: Re: [PATCH] video: s3c-fb: fix transparency length for pixel blending Message-Id: <4EBDBC17.2050208@gmx.de> List-Id: References: <1320645781-9528-1-git-send-email-jg1.han@samsung.com> In-Reply-To: <1320645781-9528-1-git-send-email-jg1.han@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-fbdev@vger.kernel.org On 11/07/2011 06:03 AM, Jingoo Han wrote: > Transparency length is fixed for pixel blending in order to support > ARGB 8888 format. > > Signed-off-by: Jingoo Han Applied this patch. Thanks, Florian Tobias Schandinat > --- > drivers/video/s3c-fb.c | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/drivers/video/s3c-fb.c b/drivers/video/s3c-fb.c > index 0753b1c..12eaee0 100644 > --- a/drivers/video/s3c-fb.c > +++ b/drivers/video/s3c-fb.c > @@ -621,7 +621,8 @@ static int s3c_fb_set_par(struct fb_info *info) > } else if (var->transp.length = 1) > data |= WINCON1_BPPMODE_25BPP_A1888 > | WINCON1_BLD_PIX; > - else if (var->transp.length = 4) > + else if ((var->transp.length = 4) || > + (var->transp.length = 8)) > data |= WINCON1_BPPMODE_28BPP_A4888 > | WINCON1_BLD_PIX | WINCON1_ALPHA_SEL; > else