From: Antti Palosaari <crope@iki.fi>
To: Malcolm Priestley <tvboxspy@gmail.com>
Cc: linux-media@vger.kernel.org
Subject: Re: [PATCH 4/7] af9013 frontend tuner bus lock and gate changes v2
Date: Sat, 12 Nov 2011 18:32:11 +0200 [thread overview]
Message-ID: <4EBE9F8B.6000808@iki.fi> (raw)
In-Reply-To: <4ebe9705.0d3ae30a.18dc.7d6f@mx.google.com>
On 11/12/2011 05:55 PM, Malcolm Priestley wrote:
> Changes from version 1
> Remove the bus lock from read status. Causing a lagging
> effect on some kernels< [2.6.38]
>
> This does mean that noisy I2C traffic could be heard on
> the first frontend when its tuner gate is open.
I think you want add locking for tuner set. But this seems to be now
removing it.
* tuner gate is not normally open, it is only open very small period
when tuner is programmed, init or sleep.
* I think gate is not reason for I2C errors seen in log
Finally I think, you want lock tuner set. Than is easiest to do locking
whole .set_frontend(). I haven't tested it, but testing it have been on
my TODO some time.
Antti
--
http://palosaari.fi/
prev parent reply other threads:[~2011-11-12 16:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-12 15:55 [PATCH 4/7] af9013 frontend tuner bus lock and gate changes v2 Malcolm Priestley
2011-11-12 16:32 ` Antti Palosaari [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EBE9F8B.6000808@iki.fi \
--to=crope@iki.fi \
--cc=linux-media@vger.kernel.org \
--cc=tvboxspy@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.