From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:33157)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1RPVjf-0004G6-Uh
	for qemu-devel@nongnu.org; Sun, 13 Nov 2011 03:48:20 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1RPVje-000642-Q1
	for qemu-devel@nongnu.org; Sun, 13 Nov 2011 03:48:19 -0500
Received: from mx1.redhat.com ([209.132.183.28]:22825)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1RPVje-0005zL-J3
	for qemu-devel@nongnu.org; Sun, 13 Nov 2011 03:48:18 -0500
Message-ID: <4EBF844D.1090206@redhat.com>
Date: Sun, 13 Nov 2011 09:48:13 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <4EBB047A.7070104@suse.de> <4EBB9A47.1020405@suse.de>
	<4EBB9F1A.3020103@suse.de>
	<5CC0A375-CD95-472E-9688-846DF13D78A1@suse.de>
	<4EBBB5AE.1050803@suse.de> <4EBE4596.6010009@suse.de>
In-Reply-To: <4EBE4596.6010009@suse.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [TestDays] s390x emulation error
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
Cc: Stefan Hajnoczi <stefanha@gmail.com>, Alexander Graf <agraf@suse.de>, qemu-devel Developers <qemu-devel@nongnu.org>

On 11/12/2011 11:08 AM, Andreas F=C3=A4rber wrote:
>
> diff --git a/main-loop.c b/main-loop.c
> index 60e9748..2ab5023 100644
> --- a/main-loop.c
> +++ b/main-loop.c
> @@ -460,7 +460,7 @@ int main_loop_wait(int nonblocking)
>       }
>
>       glib_select_poll(&rfds,&wfds,&xfds, (ret<  0));
> -    qemu_iohandler_poll(&rfds,&wfds,&xfds, ret);
> +    qemu_iohandler_poll(&rfds,&wfds,&xfds, (ret<  0));
>   #ifdef CONFIG_SLIRP
>       slirp_select_poll(&rfds,&wfds,&xfds, (ret<  0));
>   #endif

No, this is definitely wrong. :)  It will break all iohandlers.

Paolo