All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Zhi Yong Wu <zwu.kernel@gmail.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 02/10] block: add .bdrv_co_is_allocated()
Date: Mon, 14 Nov 2011 09:37:14 +0100	[thread overview]
Message-ID: <4EC0D33A.4020705@redhat.com> (raw)
In-Reply-To: <CAEH94Lg1uOdDKkuMJfOOHNtvt2hc+eNP7jEY2AFbhD50E92eCg@mail.gmail.com>

On 11/14/2011 09:10 AM, Zhi Yong Wu wrote:
>> >  No, they are necessary.  They are executed when bdrv_is_allocated_co_entry
>> >  calls qemu_coroutine_yield.
> Right, But i don't think that they are necessary.
>
> after bdrv_is_allocated_co_entry has basically completed all main
> task, it call qemu_coroutine_yield to wake up this current process; At
> that point, it is equal to the setting of data.done. Why need you
> still the three lines of codes below?

Any function _called_ by the driver's is_allocated member could call 
qemu_coroutine_yield, for example bdrv_read.

Paolo

  reply	other threads:[~2011-11-14  8:37 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-11 16:47 [Qemu-devel] [PATCH 00/10] block: replace .bdrv_is_allocated() with .bdrv_co_is_allocated() Stefan Hajnoczi
2011-11-11 16:47 ` [Qemu-devel] [PATCH 01/10] block: use public bdrv_is_allocated() interface Stefan Hajnoczi
2011-11-11 16:47 ` [Qemu-devel] [PATCH 02/10] block: add .bdrv_co_is_allocated() Stefan Hajnoczi
2011-11-14  3:04   ` Zhi Yong Wu
2011-11-14  7:32     ` Paolo Bonzini
2011-11-14  8:10       ` Zhi Yong Wu
2011-11-14  8:37         ` Paolo Bonzini [this message]
2011-11-14  8:53           ` Zhi Yong Wu
2011-11-14  8:50     ` Kevin Wolf
2011-11-14  8:50       ` Zhi Yong Wu
2011-11-11 16:47 ` [Qemu-devel] [PATCH 03/10] qed: convert to .bdrv_co_is_allocated() Stefan Hajnoczi
2011-11-11 16:47 ` [Qemu-devel] [PATCH 04/10] block: convert qcow2, qcow2, and vmdk " Stefan Hajnoczi
2011-11-11 16:47 ` [Qemu-devel] [PATCH 05/10] vvfat: use public block layer interface Stefan Hajnoczi
2011-11-11 16:59   ` Kevin Wolf
2011-11-14 11:47     ` Stefan Hajnoczi
2011-11-11 16:47 ` [Qemu-devel] [PATCH 06/10] vvfat: convert to .bdrv_co_is_allocated() Stefan Hajnoczi
2011-11-11 16:47 ` [Qemu-devel] [PATCH 07/10] vdi: " Stefan Hajnoczi
2011-11-11 16:47 ` [Qemu-devel] [PATCH 08/10] cow: " Stefan Hajnoczi
2011-11-11 16:47 ` [Qemu-devel] [PATCH 09/10] block: drop .bdrv_is_allocated() interface Stefan Hajnoczi
2011-11-11 16:47 ` [Qemu-devel] [PATCH 10/10] block: add bdrv_co_is_allocated() interface Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EC0D33A.4020705@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=zwu.kernel@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.