All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Arend van Spriel" <arend@broadcom.com>
To: "Joe Perches" <joe@perches.com>
Cc: "John W. Linville" <linville@tuxdriver.com>,
	linux-wireless <linux-wireless@vger.kernel.org>,
	netdev <netdev@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] brcmsmac: Use current logging styles
Date: Mon, 14 Nov 2011 11:13:43 +0100	[thread overview]
Message-ID: <4EC0E9D7.7080304@broadcom.com> (raw)
In-Reply-To: <1321213264.15834.4.camel@Joe-Laptop>

On 11/13/2011 08:41 PM, Joe Perches wrote:
> Add and use pr_fmt and pr_<level>
> Remove useless double parentheses from macros.
> Remove function names from format strings, add to pr_debug use.
> Coalesce formats.
> Remove uncompileable undeclared variable in a DMA_NONE use.
> 
> Signed-off-by: Joe Perches <joe@perches.com>
> ---
>  drivers/net/wireless/brcm80211/brcmsmac/aiutils.c |   14 +-
>  drivers/net/wireless/brcm80211/brcmsmac/dma.c     |  145 ++++++++++-----------
>  2 files changed, 80 insertions(+), 79 deletions(-)

Thanks for the service.

Acked-by: Arend van Spriel <arend@broadcom.com>

Gr. AvS



      parent reply	other threads:[~2011-11-14 10:13 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-13 19:41 [PATCH] brcmsmac: Use current logging styles Joe Perches
2011-11-13 19:41 ` Joe Perches
2011-11-14  1:08 ` Stephen Hemminger
2011-11-14  1:08   ` Stephen Hemminger
2011-11-14  1:10   ` Joe Perches
2011-11-14 10:13 ` Arend van Spriel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EC0E9D7.7080304@broadcom.com \
    --to=arend@broadcom.com \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.