From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] tt01: add MMC and video support
Date: Mon, 14 Nov 2011 12:21:43 +0100 [thread overview]
Message-ID: <4EC0F9C7.4050001@denx.de> (raw)
In-Reply-To: <1319731903-17127-1-git-send-email-helmut.raiger@hale.at>
On 10/27/2011 06:11 PM, Helmut Raiger wrote:
> board_mmc_init() initializes the pins of SDHC1 and
> turns on V_MMC1 of the PMIC. The video setup for
> the Epson display is provided along with some fancy
> extra info to be displayed next to the HALE logo.
>
> Signed-off-by: Helmut Raiger <helmut.raiger@hale.at>
> ---
Hi Helmut,
> +
> + /* configure pins for SDHC1 only */
> + mx31_gpio_mux(IOMUX_MODE(MUX_CTL_SD1_CLK, MUX_CTL_FUNC));
> + mx31_gpio_mux(IOMUX_MODE(MUX_CTL_SD1_CMD, MUX_CTL_FUNC));
> + mx31_gpio_mux(IOMUX_MODE(MUX_CTL_SD1_DATA0, MUX_CTL_FUNC));
> + mx31_gpio_mux(IOMUX_MODE(MUX_CTL_SD1_DATA1, MUX_CTL_FUNC));
> + mx31_gpio_mux(IOMUX_MODE(MUX_CTL_SD1_DATA2, MUX_CTL_FUNC));
> + mx31_gpio_mux(IOMUX_MODE(MUX_CTL_SD1_DATA3, MUX_CTL_FUNC));
> +
> + /* turn on power V_MMC1, bit 18 is the VMMC1 enable */
> + if (pmic_reg_read(p, 33, &val) < 0)
> + pmic_reg_write(p, 33, val | 0x040000);
> +
> + return mxc_mmc_init(bis);
> +}
> +#endif
> +
I have no issue regarding MMC support....
> index 0000000000000000000000000000000000000000..efdbb4d097abb7ba7ac69e6960030ecb7e19e3cc
> GIT binary patch
> literal 27238
> zcmeHOy^Acz5ua&>WoLJ0Zuj<P@0PdgP#8He4unIaT(SOx7YM9CSOO=;nM0*c491zk
> znZd!sT%Z>S<3tk12n3Q7gFf&_Vg~|0{Hv<&>h9UuW8R_dxre6UW at oymKYsPAuCDH$
> zd-b))Z)7a56j}CN-2EGWKgM64%{l%1kF)IQLjE`bmuJtOW&ir at qwL9>FX8Xy?0?U`
> z&b~(4`@eWCyT$V@(!c!hN%r(-KgyoG^-}h?KmIEF1JeHc&(E{lw||g*{M(;r|M}um
> z<b5yu;FpiHfBf~m?C<aYF8lQN?`D7b^-r?fw_eWv{O;@7?K`hzUw!hY?4#ejnLYjK
> z4_))q at 1%iA10!nSJCjTrm^3hHVA8;(fk^|C1||(m8kjUNX<*X8q=88T-+B!c4@=I@
> z2gA+F(IpqXr at -4@7%#P{{e#~1rD^6ja#JrVLYx3^Wz1|py3C9rz~{%?EKMu6H14%s
> znkEI_%B;o(>RP`hg3r(ImhFfdZQ2#263@}Lj`h5v<aX`)Rg_zL1{ow&rfN{OEhT}k
> zTn5Q3VP4smNG)4eJgBTR`;>T_)zUhin at 2^F8&gZqF|b5t();R09&hMzec*?xfD>3q
> zKCbyrURkafacRtj%UhZnwc{#Ut*oo0vT5-)(sS-8m<3)#eZ;5&a!RdfcooHl?n!p^
> zw2=F%Xal^JD6U4a8!Cf5#XC0!b|BZHA-!<rR9RZQ2Q<8Zl{M|I7QDnS!8RK(Qf?PD
> z_5B*pJG=&iwb`?#fGG$3Qke_ba=yZi5a;nm{O(O%BOHZ@*wU^Zx!Bo})oeu)4#
> zj%hd&7ABToB<7aPddM&A{lX@KXsG2Bzp!&{6ZIwK7o(I1q~Ks+;FsV<-W&MC*D6!H
> zQLXk2bhUF`V0hjDNDsew1#S8<pB67B;hN){05AB3mCC5K$#_k@IVB<AvJI5B?-<}#
> z2XJR7-}dl}YVx8%X4qy*esg#Yu|bOr%!1#2(09rp3-t36;jJxRKYr(?_9g)*xa#2-
> z at 06qlb_uq{r1p%q&0<Ev*RA!>;A+XKa%t$bP%VA at Mkas?c0K&gYk28yWhwckw!PGQ
> z!YlmRRGu~RZWsIb?cl`#?;XE6<8|DM@uZ742na<{B(OopFD8sjNnFw7vOdNejNiF*
> z{<7}cGfG)6PLYPrzf_rB1#-!h{F3j$EX0EOq_X^O)e8|x%Oe*P@oPH|7asYmii#3Q
> z5;!o8ugIB=<*z7Ef;HJL!6(s7R1}ZUJxc+g0|urL4VCb6G=A+|iZq?F;qSmK5ozak
> z+)@}L at f9jNaFcRL$uISMDabaa#>^t)m#0W}P-}D%WDr$WFVsnomrx4K1|ji<IB`nE
> z+f>LB4Dt!0#LuLMpt7WR3yj)j1zv4LCHxj8#@nK7)-AFx3HT0<Yt}YRUX@to!2K?;
> zkU|8;c+I}ddAc=os)}MyinM?irB>@E$NL<=$S9V|N~w%q1Nda?!SyBjV$cy&Ujvur
> zS8!0OGg25K1O#2X#R8isxRM;$2239Ug8*Ez8Q|SXCZ&+pF#nRbXlCs8 at g~un7H`qO
> zkg1Ds&JfEldU24{gA1d#g1+96NkD1{V&uBME-|fgl$9@}jM?y5K;EX=P!g6TJZP4+
> z4LP?|1Tq3%IL`{ZSau=q_yzPw+x>p)(2_3N6(wK+bajpR`3eH6uC9O$708QMxYI2H
> z<Y7GLRE>4hITaCcl_lrbbwGZV-#EGR<o#7A<35jx?K$pZz;B!pJ>3`YY$3a^QDtM}
> z<^7GQM@J7n-Z;v-GXX9jj5OrkRCwcspzY@{ev5MNHVN*;*UiLSz+N#*PlZ>bp|JJ!
> zViB&z!>n)Mesz8Awgh}_ZJPPF_2I5>dyKmoDgONN2Ev9tPm^O{^lh&9H3e`9 at a7Ug
> z at Vr0f<&r{?1b8WIe-J`0`}}xm5AI<IZ3>(pudHky1Y!_;e!Q}pc at TILtp@|Fc3l&s
> z at U14xBBz_(eb(2z8U4?6(8Q7y at 6EQVa7fhc(tL$vKE*?~c2!kvddK at 7IkLvB4HY?(
> zJ+Ft&1zI^0+C(5piC31YSOmwilc|}L=d#u-rRU*$2ifZrSAYYwK6ylXvek9-?G%v^
> zubv9o(_M?^;QCJ7xsdm00 at L#%w}aEg!_UwLACLBBVq*`I5U(y*VlWOO?J+L3qxRI7
> z`$!kvf2D0*f0&~0%MCKMx=t2vVWz~Z4AEwj7oUvHVl at G~LFHdlWzojt at j}3Xb6a5U
> zIrydRg_L;RemHNgc_4oOA9(#<aoO=|&gl90z-`+HXyg`{!d;;#Uq*g9d-kkESZdv7
> zf-&luNKwRtT+Nw}4`dfRLL(2@={<#)_N+(ZS1ij>teuY!KiX|5-hwH1Il=GRZfy4`
> zqA0EYM&Z{%rQe8Occ9(ZW1EH at T6g|}ElX?}sL0-}@|$Z0ZX^%QrNcX9{2HUyeF8H3
> zI^~y~bw?C04yJk}9o`}1_l~K?;-{!2;P)7j;-&8ijwKyl&+i at M*Ib_9)h5fzauC09
> zD-L-&yaB(iar%wN?`i)kfO%3G#_v_wir%Ng>-ml2jmSUi$2ccwmi5Am%&+%Q*7^9z
> z;uy2o=rDf6@#}~382mQj%(_*4H2*?00B$aqEOQ at h*o}ih{6?+lS!p`Fe*7Nu#wnIx
> zzXwm at 1Ef|B6cQs1<2P=FPSr`$;q~J;?ukBGetq;L5pOX4xPd>2U#(YelCOV<@{2FC
> ztO((?UqslQg8T5x-~BvHe*F|I2Cb`I-PXMizXh9fLVF&{Z!iVRY^&(3eFp}9S3K#g
> zBr=wScn6PP_dOk!1GJ6hKgLogs~UI?ytEGlN$0PI^XtDCC4<(}UkwoNGk)n?MUr%Q
> zJ->PIJ?w0zAOAZ498AG*s$Na5%fb5hE`Fm{bb~h?Uf*#yt+2wo at iQgr6bwA}6H$yp
> znS7BwjNdT6;+FW54zK4o!W->hxqj&Y-H`!`1f?|lE`DE(^{*gSkd at z$ve6b^c+vP(
> z$HU+{>myFnedq at Niy@+uFJ2hLZ`=x3i%U9teva`QOu-s#xXBlN9>(tjUH|ruUq1y~
> zcJ<%Ph^JwAV}9L=a1?%B<J@`Op^Kc4Gh>H0>^*<@${A4+sx7dLq6wv1N~7uUdjA~u
> zJs``^zv#AK0}5h4`65$?{GE86s^qufkCDe8zeoEUL{fN?B;5 at UNC)y8<1MyK@EH6C
> zGbxa%vyJ%mW0bocA1P{)=irw=w@&Gw{Y)CTTHw`_zZjE-&5YMizC^wndt8LFe03dq
> z?Wtr!el<#r&vx|;RF^;8Z?7J7Jl2puMvT?K<+PP9Uhx14@w(8^uFM1#uJpeQkfV=y
> z^rYZ8>r at e{Gd2vV8`rfg8B*dki)y`YJ2aw)Cz8#f%Gc|4Ug=>M!4Wz1*Tk7K<aH&t
> z{}Mr;2Au!<t7rmpT^{Eb2dn4D%l`#54!*cm{@2<Bc=?~!<EF=Ws`*=`6nKkrwHsYl
> o;sKN3RX;iY&Drrz4NMxCG%#sk(!ivFNduDxCJjs)_%>_c|AT7s*8l(j
>
...but I am asking myself if it makes sense to add all these blobs to
U-Boot.
I know there are other examples in U_Boot, it is not bad they are only a
few. I do not know if this should be competence for the video maintainer
or generally for the project, so I added both custodians. By the way,
should it not possible to get what you want with CONFIG_CMD_BMP (you
have already set it) and CONFIG_PREBOOT to load your image from the
media you prefer (and you could also exchange it without recompiling
U-Boot) instead of adding it to the U-Boot image ?
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================
next prev parent reply other threads:[~2011-11-14 11:21 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-27 16:11 [U-Boot] [PATCH] tt01: add MMC and video support Helmut Raiger
2011-10-27 16:16 ` Helmut Raiger
2011-11-14 11:21 ` Stefano Babic [this message]
2012-01-19 12:08 ` [U-Boot] [PATCH] tt01: add MMC and video support --> howto avoid LOGO blobs Helmut Raiger
2012-01-30 14:21 ` [U-Boot] [PATCH] tt01: add video support and setup for release Helmut Raiger
2012-01-30 14:21 ` [U-Boot] [PATCH 1/3] tt01: fix environment size Helmut Raiger
2012-02-17 8:48 ` Stefano Babic
2012-01-30 14:21 ` [U-Boot] [PATCH 2/3] tt01: add video support Helmut Raiger
2012-02-15 15:52 ` Stefano Babic
2012-02-16 8:40 ` [U-Boot] [PATCH V2 " Helmut Raiger
2012-02-17 8:48 ` Stefano Babic
2012-01-30 14:21 ` [U-Boot] [PATCH 3/3] tt01: fix hush parser config, add release config Helmut Raiger
2012-02-15 14:36 ` [U-Boot] [PATCH 3/3] imx31: " Helmut Raiger
2012-02-15 15:40 ` Stefano Babic
2012-02-17 8:48 ` [U-Boot] [PATCH 3/3] " Stefano Babic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EC0F9C7.4050001@denx.de \
--to=sbabic@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.