From mboxrd@z Thu Jan 1 00:00:00 1970 From: Helmut Raiger Date: Mon, 14 Nov 2011 16:37:46 +0100 Subject: [U-Boot] [PATCH V2] imx: mmc: access mxcmmc from mx31 boards In-Reply-To: <4EC0F392.60000@denx.de> References: <4EA684D5.8030608@denx.de> <1319717957-30517-1-git-send-email-helmut.raiger@hale.at> <4EB0EB13.2070404@hale.at> <4EB78FE8.5000308@hale.at> <4EB79F25.1000009@denx.de> <4EC0D9FD.6090705@hale.at> <4EC0F392.60000@denx.de> Message-ID: <4EC135CA.1090502@hale.at> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 11/14/2011 11:55 AM, Stefano Babic wrote: > On 11/14/2011 10:06 AM, Helmut Raiger wrote: >> Hi, >> > Hi Helmut, > >> Stefano I don't want to be pushing, but this sits here since 3 >> weeks, can I be of some help? > in my answer I post the question about the fact there is no use case for > this code until you will submit also the patch for your board adding > MMC. So please resubmit both as patchset, else this single patch is as > dead code, and this is not accepted in u-boot, even if it is a > preparation for further patches - we cannot know if and then the follow > up patches will be sent. > >> Concerning the TT-01 extension patch, I meant it has to wait until this >> patch is through. > No, we do not add code that is never compiled. And it is easier to see > some problem in review if it is shown as the code is used. > >> So if you don't like the idea of having a patch no-one is using, > Yes, I do not like it. > >> simply >> apply both of them. >> For your reference: >> >> http://patchwork.ozlabs.org/patch/122139/ this one >> http://patchwork.ozlabs.org/patch/122176/ board support >> extension > Does it mean the last patch is ready for review ? Then I will go on with > both. > > Best regards, > Stefano Babic > Hi Stefan, I will check the proposition you made for the board support extension (which removes the awkward HALE logo from the u-boot source tree, which didn't feel quite right when I was adding it.) So you may ignore these for now and I will send a patch set that contains both patches with your suggested changes. Thanx, Helmut -- Scanned by MailScanner.