All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ilya Yanok <yanok@emcraft.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-input@vger.kernel.org, wd@denx.de, dzu@denx.de,
	sasha_d@emcraft.com, Anatolij Gustshin <agust@denx.de>
Subject: Re: [PATCH] edt_ts: EDT Touchscreen driver
Date: Tue, 15 Nov 2011 01:07:57 +0400	[thread overview]
Message-ID: <4EC1832D.3080405@emcraft.com> (raw)
In-Reply-To: <20111114172809.GD12659@core.coreip.homeip.net>

Hi Dmitry,

On 14.11.2011 21:28, Dmitry Torokhov wrote:
>> +	irq = gpio_to_irq(pdata->irq_gpio);
>> +	if (irq < 0) {
>> +		dev_err(&client->dev, "can't get IRQ for GPIO\n");
>> +		error = -EINVAL;
>> +		goto err0;
>> +	}
> 
> Why can't we use client->irq?

Well, my idea was to avoid duplication (passing both GPIO and IRQ
numbers) and I can't pass only client->irq as we need GPIO number also
and irq_to_gpio is not guaranteed to work with arbitrary IRQ number.

Thanks for your comments! I'll address them and repost the patch.

Regards, Ilya.

  reply	other threads:[~2011-11-14 21:47 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-08 23:34 [PATCH] edt_ts: EDT Touchscreen driver Ilya Yanok
2011-11-14 17:28 ` Dmitry Torokhov
2011-11-14 21:07   ` Ilya Yanok [this message]
2011-11-14 21:32     ` Dmitry Torokhov
2011-11-15  9:17       ` Anatolij Gustschin
2011-11-15  9:30         ` Dmitry Torokhov
2011-11-15 17:41         ` Dmitry Torokhov
2011-11-16 20:44           ` Ilya Yanok
2011-11-17 12:20             ` Anatolij Gustschin
2011-11-20 18:09   ` Ilya Yanok
2011-11-20 18:36     ` Dmitry Torokhov
2011-11-20 19:22       ` Ilya Yanok
     [not found] ` <CAM=Q2cuv_OFdrHpmf-fSRkiaz0X07vHpbpWH=MzfR_3S4OADjg@mail.gmail.com>
2011-11-21  9:24   ` Anatolij Gustschin
2011-11-30  9:34 ` Simon Budig
2011-12-14 23:49   ` Ilya Yanok

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EC1832D.3080405@emcraft.com \
    --to=yanok@emcraft.com \
    --cc=agust@denx.de \
    --cc=dmitry.torokhov@gmail.com \
    --cc=dzu@denx.de \
    --cc=linux-input@vger.kernel.org \
    --cc=sasha_d@emcraft.com \
    --cc=wd@denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.