All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rick Jones <rick.jones2@hp.com>
To: Ben Hutchings <bhutchings@solarflare.com>
Cc: netdev@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	Michael Tsirkin <mst@redhat.com>
Subject: Re: [RFC PATCH net-next] enable virtio_net to return bus_info in ethtool -i consistent with emulated NICs
Date: Mon, 14 Nov 2011 16:14:34 -0800	[thread overview]
Message-ID: <4EC1AEEA.903@hp.com> (raw)
In-Reply-To: <1321315839.2827.25.camel@bwh-desktop>

>>> Please use the existing 'not implemented' value, which is the empty
>>> string.   If you think ethtool should print some helpful message instead
>>> of an empty string, please submit a patch for ethtool.
>>
>>
>> One question - will those actually be called via an ethtool path?  In my
>> poking about through the virtio code, I got the impression those modules
>> were for "other than networking" sorts of things.
>
> I don't know; I just assumed that was why you were adding them!  In
> other contexts such as dev_printk() this string would make even less
> sense.

Those were added to make sure there were no dangling references in the 
config_ops structure defined in those files and that the code calling 
through wouldn't go off into la-la land.  Perhaps it isn't necessary 
with Rusty's suggestion that I check ".bus_info" against NULL? But that 
is why those were there, and not simply the instance in virtio_pci.c. 
I'll spin a v2 regardless.

rick

  reply	other threads:[~2011-11-15  0:14 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-14 21:52 [RFC PATCH net-next] enable virtio_net to return bus_info in ethtool -i consistent with emulated NICs Rick Jones
2011-11-14 22:30 ` Ben Hutchings
2011-11-14 22:30 ` Ben Hutchings
2011-11-14 22:40   ` Rick Jones
2011-11-14 22:40   ` Rick Jones
2011-11-15  0:06   ` Rick Jones
2011-11-15  0:10     ` Ben Hutchings
2011-11-15  0:10     ` Ben Hutchings
2011-11-15  0:14       ` Rick Jones [this message]
2011-11-15  0:06   ` Rick Jones
  -- strict thread matches above, loose matches on Subject: below --
2011-11-14 21:52 Rick Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EC1AEEA.903@hp.com \
    --to=rick.jones2@hp.com \
    --cc=bhutchings@solarflare.com \
    --cc=mst@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.