From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.free-electrons.com ([88.190.12.23]:53612 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753736Ab1KOKX6 (ORCPT ); Tue, 15 Nov 2011 05:23:58 -0500 Message-ID: <4EC23DB6.1040503@free-electrons.com> Date: Tue, 15 Nov 2011 11:23:50 +0100 From: Maxime Ripard MIME-Version: 1.0 To: Jonathan Cameron CC: linux-arm-kernel@lists.infradead.org, linux-iio@vger.kernel.org, Nicolas Ferre , Patrice Vilchez , Jean-Christophe Plagniol-Villard , Thomas Petazzoni Subject: Re: [PATCH 2/3] ARM: AT91: IIO: Add AT91 ADC driver. References: <1321291857-26277-1-git-send-email-maxime.ripard@free-electrons.com> <1321291857-26277-3-git-send-email-maxime.ripard@free-electrons.com> <4EC188D2.5080706@kernel.org> In-Reply-To: <4EC188D2.5080706@kernel.org> Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-iio-owner@vger.kernel.org List-Id: linux-iio@vger.kernel.org On 14/11/2011 22:32, Jonathan Cameron wrote: > Just one more query on the IIO_CHAN_INFO_SCALE read. > Sorry, missed this last time. Its late so I may be going > mad but the units seem out by 1000. Wow, you're right. Indeed, if you multiply the value returned by read_raw and scale, you get a value in millivolts, not micro... > Also mysterious short as return value type in read_raw. I will resend a new patchset with these two fixes. Maxime -- Maxime Ripard, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com From mboxrd@z Thu Jan 1 00:00:00 1970 From: maxime.ripard@free-electrons.com (Maxime Ripard) Date: Tue, 15 Nov 2011 11:23:50 +0100 Subject: [PATCH 2/3] ARM: AT91: IIO: Add AT91 ADC driver. In-Reply-To: <4EC188D2.5080706@kernel.org> References: <1321291857-26277-1-git-send-email-maxime.ripard@free-electrons.com> <1321291857-26277-3-git-send-email-maxime.ripard@free-electrons.com> <4EC188D2.5080706@kernel.org> Message-ID: <4EC23DB6.1040503@free-electrons.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 14/11/2011 22:32, Jonathan Cameron wrote: > Just one more query on the IIO_CHAN_INFO_SCALE read. > Sorry, missed this last time. Its late so I may be going > mad but the units seem out by 1000. Wow, you're right. Indeed, if you multiply the value returned by read_raw and scale, you get a value in millivolts, not micro... > Also mysterious short as return value type in read_raw. I will resend a new patchset with these two fixes. Maxime -- Maxime Ripard, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com