Hi Dave, Thanks for the comments, David Miller wrote: > From: Srinivas KANDAGATLA > Date: Wed, 9 Nov 2011 13:38:51 +0000 > >> + mdio_gpio_ops.reset = pdata->reset; > > What if I have multiple types of devices backing a mdio_gpio, each using > different reset operations? > > You can't write this variable method into a globally used set of ops. I agree with your comment. Here is the modified patch, which moves the reset function pointer to mdiobb_ctrl struct. Thanks srini