From: sshtylyov@mvista.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 2/4] ARM: davinci: psc: fix incorrect offsets
Date: Tue, 15 Nov 2011 16:18:45 +0400 [thread overview]
Message-ID: <4EC258A5.3030207@mvista.com> (raw)
In-Reply-To: <1321301529-7582-2-git-send-email-nsekhar@ti.com>
Hello.
On 15-11-2011 0:12, Sekhar Nori wrote:
> From: Murali Karicheri<m-karicheri2@ti.com>
> Seperate PDSTAT and PDCTL registers are defined for
> domain 0 and domain 1 where as the code always reads
> the domain 0 PDSTAT register and domain 1 PDCTL register.
> Fix this issue. While at it, introduce usage of macros
> for register masks to improve readability.
> Reviewed-by: Sergei Shtylyov<sshtylyov@mvista.com>
> Signed-off-by: Murali Karicheri<m-karicheri2@ti.com>
> Signed-off-by: Sekhar Nori<nsekhar@ti.com>
> ---
> arch/arm/mach-davinci/include/mach/psc.h | 4 +++-
> arch/arm/mach-davinci/psc.c | 16 ++++++++--------
> 2 files changed, 11 insertions(+), 9 deletions(-)
> diff --git a/arch/arm/mach-davinci/include/mach/psc.h b/arch/arm/mach-davinci/include/mach/psc.h
> index 8bf279a..8bc3fc2 100644
> --- a/arch/arm/mach-davinci/include/mach/psc.h
> +++ b/arch/arm/mach-davinci/include/mach/psc.h
[...]
> @@ -246,6 +246,8 @@
> #define MDSTAT_STATE_MASK 0x3f
> #define PDSTAT_STATE_MASK 0x1f
> #define MDCTL_FORCE BIT(31)
> +#define PDCTL_NEXT BIT(1)
BIT(0) actually.
WBR, Sergei
prev parent reply other threads:[~2011-11-15 12:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-14 20:12 [PATCH v4 1/4] ARM: davinci: psc: fix incorrect mask Sekhar Nori
2011-11-14 20:12 ` [PATCH v4 2/4] ARM: davinci: psc: fix incorrect offsets Sekhar Nori
2011-11-14 20:12 ` [PATCH 3/4] ARM: davinci: dm646x does not have a DSP domain Sekhar Nori
2011-11-14 20:12 ` [PATCH v4 4/4] ARM: davinci: add support for multiple power domains Sekhar Nori
2011-11-15 12:18 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EC258A5.3030207@mvista.com \
--to=sshtylyov@mvista.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.