From: Avi Kivity <avi@redhat.com>
To: Sasha Levin <levinsasha928@gmail.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
Pawel Moll <pawel.moll@arm.com>,
kvm@vger.kernel.org, asias.hejun@gmail.com,
virtualization@lists.linux-foundation.org, penberg@kernel.org,
gorcunov@gmail.com, mingo@elte.hu
Subject: Re: [RFC] kvm tools: Add support for virtio-mmio
Date: Tue, 15 Nov 2011 20:14:04 +0200 [thread overview]
Message-ID: <4EC2ABEC.1040007@redhat.com> (raw)
In-Reply-To: <1321379773.3200.9.camel@lappy>
On 11/15/2011 07:56 PM, Sasha Levin wrote:
> >
> > This isn't a PCI device, so does it make sense to use a PCI vendor
> > ID here? The kernel doesn't check the vendor ID at the moment,
> > but presumably the idea of the field is to allow the kernel to
> > work around implementation bugs/blacklist/whatever if necessary.
> > If that's the theory then it would make more sense for QEMU and
> > kvm-tool to use IDs that say "this is the QEMU implementation"
> > and "this is the kvm-tool implementation".
> >
> > (I picked 0x554D4551 for QEMU...)
> >
> > -- PMM
>
> I just sheepishly filled in the only vendor ID I knew of in the virtio
> spec :)
>
> Hmm... If thats the plan, it should probably be a virtio thing (not
> virtio-mmio specific).
>
> Either way, it could also use some clarification in the spec.
The spec only covers virtio-pci; this virtio-mmio is completely
unspec'ed. IMO it's a timebomb waiting to explode.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2011-11-15 18:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-15 16:47 [RFC] kvm tools: Add support for virtio-mmio Sasha Levin
2011-11-15 17:00 ` Peter Maydell
2011-11-15 17:56 ` Sasha Levin
2011-11-15 18:14 ` Avi Kivity [this message]
2011-11-15 18:13 ` Sasha Levin
2011-11-15 18:18 ` Avi Kivity
2011-11-15 18:22 ` Sasha Levin
2011-11-16 13:21 ` Pawel Moll
2011-11-16 13:21 ` Pawel Moll
2011-11-16 13:30 ` Sasha Levin
2011-11-16 13:30 ` Sasha Levin
2011-11-15 17:00 ` Peter Maydell
-- strict thread matches above, loose matches on Subject: below --
2011-11-15 16:47 Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EC2ABEC.1040007@redhat.com \
--to=avi@redhat.com \
--cc=asias.hejun@gmail.com \
--cc=gorcunov@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=levinsasha928@gmail.com \
--cc=mingo@elte.hu \
--cc=pawel.moll@arm.com \
--cc=penberg@kernel.org \
--cc=peter.maydell@linaro.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.