From: Lars-Peter Clausen <lars@metafoo.de>
To: Jonathan Cameron <jic23@kernel.org>
Cc: Jonathan Cameron <jic23@cam.ac.uk>,
Michael Hennerich <michael.hennerich@analog.com>,
linux-iio@vger.kernel.org,
device-drivers-devel@blackfin.uclinux.org, drivers@analog.com
Subject: Re: [PATCH] staging:iio: Add missing MODULE_DEVICE_TABLE and MODULE_ALIAS
Date: Tue, 15 Nov 2011 21:27:49 +0100 [thread overview]
Message-ID: <4EC2CB45.8030308@metafoo.de> (raw)
In-Reply-To: <4EC2C16B.5040400@kernel.org>
On 11/15/2011 08:45 PM, Jonathan Cameron wrote:
> On 11/15/2011 04:14 PM, Lars-Peter Clausen wrote:
>> Quite a few iio drivers provide no MODULE_DEVICE_TABLE or MODULE_ALIAS or only
>> provide a MODULE_ALIAS while they have support for multiple device ids. This
>> prevents auto module loading from working correctly.
>>
> Sensible patch. I've never chased this down because I'm cynical and
> tend to specifically load drivers for my devices. This will have
> fuzz all over the place, so you may end up rebasing to get it in.
> I'd like this to happen asap though as things are moderately quiet at
> the moment!
I'm don't use module auto loading myself that much, but these kind of issues
tend to spread as previous drivers are used as skeletons for new ones.
In regard to the fuzz, I've collected the IIO patches which were sent to GregKH
but haven't been applied yet[1] and based this patch on top of it.
Btw. I see you have a new email address. Which one should we send patches too?
>> This patch fixes it by adding the missing MODULE_DEVICE_TABLEs and
>> MODULE_ALIAS'.
>>
>> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
> Acked-by: Jonathan Cameron <jic23@kernel.org>
Thanks
- Lars
[1] http://git.metafoo.de/?p=linux-2.6;a=shortlog;h=refs/heads/iio-queue
next prev parent reply other threads:[~2011-11-15 20:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-15 16:14 [PATCH] staging:iio: Add missing MODULE_DEVICE_TABLE and MODULE_ALIAS Lars-Peter Clausen
2011-11-15 19:45 ` Jonathan Cameron
2011-11-15 20:27 ` Lars-Peter Clausen [this message]
2011-11-15 20:30 ` Jonathan Cameron
-- strict thread matches above, loose matches on Subject: below --
2011-11-16 7:53 Lars-Peter Clausen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EC2CB45.8030308@metafoo.de \
--to=lars@metafoo.de \
--cc=device-drivers-devel@blackfin.uclinux.org \
--cc=drivers@analog.com \
--cc=jic23@cam.ac.uk \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=michael.hennerich@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.