From mboxrd@z Thu Jan 1 00:00:00 1970 From: Milan Broz Date: Tue, 15 Nov 2011 23:23:44 +0100 Subject: [PATCH] Fix RHBZ 754198 (multiple dmeventd snapshot extensions) In-Reply-To: <87pqgtxczr.fsf@aldalome.int.mornfall.net.> References: <87pqgtxczr.fsf@aldalome.int.mornfall.net.> Message-ID: <4EC2E670.6000208@redhat.com> List-Id: To: lvm-devel@redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On 11/15/2011 11:00 PM, Petr Rockai wrote: > the attached patch should fix the problem encountered in 754198. Namely, > we failed to reset the percent threshold for the next check after > extending a snapshot. To this end, I have added a special exit code, > ENO_ACTION_NEEDED -- however, this is not absolutely required, and is > only an optimisation. On the other hand, it is likely an important > optimisation, because without this, all snapshots filled above 50 % will > run a LVM command (with all the associated overhead) every 10 > seconds. There are more possible uses for this new exit code, so I think > it's a good idea anyway. > > Documentation *might* need updating (although it's currently only used > by --use-policies, which is not an entirely user-level option...). > > Other than that, the patch is relatively straightforward. For me this seems ok, ack. (dmeventd/lvm interaction through calling lvm binary strange anyway...) Milan