From: Denis Kuzmenko <linux@solonet.org.ua>
To: Stephen Warren <swarren@nvidia.com>
Cc: Wolfram Sang <w.sang@pengutronix.de>,
Dong Aisheng <dong.aisheng@linaro.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Grant Likely <grant.likely@secretlab.ca>
Subject: Re: [PATCH] gpio: add flags to export GPIOs when requesting
Date: Wed, 16 Nov 2011 10:19:10 +0200 [thread overview]
Message-ID: <4EC371FE.5010402@solonet.org.ua> (raw)
In-Reply-To: <74CDBE0F657A3D45AFBB94109FB122FF1740805F1A@HQMAIL01.nvidia.com>
Hi Stephen,
On 11/16/2011 01:32 AM, Stephen Warren wrote:
> Denis Kuzmenko wrote at Tuesday, November 15, 2011 4:05 PM:
>> Hi Wolfram,
>> On 11/16/2011 12:44 AM, Wolfram Sang wrote:
>>
>> #define GPIOF_EXPORT (1 << 2)
>> #define GPIOF_EXPORT_DIR_CHANGEABLE (3 << 2)
>
> Then you won't have a single flag to check if the dir is changeable.
>
> Personally, I'd go for the two single-bit flags, and force boards to OR
> them together if they want the GPIO exported and with a changeable
> direction; just get rid of the two _DIR_ flags. That said, Wolfram's
> patch seems to follow the conventions already in the file.
Your truth.
> Dong Aisheng posted patch "gpio: introduce gpio_export_array to ease
> export for gpio arrays". Which should we pick; it doesn't seem like we
> need both mechanisms.
I vote for GPIOF_* variant (this one) since it can deal with different
settings for each gpio pin in array.
--
Best regards, Denis Kuzmenko.
next prev parent reply other threads:[~2011-11-16 8:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-15 22:44 [PATCH] gpio: add flags to export GPIOs when requesting Wolfram Sang
2011-11-15 23:05 ` Denis Kuzmenko
2011-11-15 23:32 ` Stephen Warren
2011-11-16 8:19 ` Denis Kuzmenko [this message]
2011-11-16 9:10 ` Wolfram Sang
2011-11-16 15:57 ` Stephen Warren
2011-11-17 9:10 ` Linus Walleij
2011-11-17 9:31 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EC371FE.5010402@solonet.org.ua \
--to=linux@solonet.org.ua \
--cc=dong.aisheng@linaro.org \
--cc=grant.likely@secretlab.ca \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=swarren@nvidia.com \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.