From: robherring2@gmail.com (Rob Herring)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm: device.h: Add dma_mask to pdev_archdata structure
Date: Wed, 16 Nov 2011 07:19:00 -0600 [thread overview]
Message-ID: <4EC3B844.3060402@gmail.com> (raw)
In-Reply-To: <20111116082926.GE9581@n2100.arm.linux.org.uk>
On 11/16/2011 02:29 AM, Russell King - ARM Linux wrote:
> On Wed, Nov 16, 2011 at 01:46:18AM -0200, Fabio Estevam wrote:
>> Fix the following build error when doing a 'make mx3_defconfig'
>>
>> CC [M] drivers/usb/host/fsl-mph-dr-of.o
>> drivers/usb/host/fsl-mph-dr-of.c: In function 'fsl_usb2_device_register':
>> drivers/usb/host/fsl-mph-dr-of.c:97: error: 'struct pdev_archdata' has no member named 'dma_mask'
>> make[3]: *** [drivers/usb/host/fsl-mph-dr-of.o] Error 1
>> make[2]: *** [drivers/usb/host] Error 2
>> make[1]: *** [drivers/usb] Error 2
>> make: *** [drivers] Error 2
>
> Why is this required for just MX3? Why should we take the hit of adding
> this (needlessly) for the other sub-architectures? Why is MX3 doing this
> differently?
This or some way to populate a dma_mask value is needed for devicetree
based probing.
That being said, fsl-mph-dr-of.c directly accessing struct pdev_archdata
is not right either.
Rob
next prev parent reply other threads:[~2011-11-16 13:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-16 3:46 [PATCH] arm: device.h: Add dma_mask to pdev_archdata structure Fabio Estevam
2011-11-16 8:29 ` Russell King - ARM Linux
2011-11-16 10:26 ` Uwe Kleine-König
2011-11-16 13:19 ` Rob Herring [this message]
2011-12-20 7:13 ` Dirk Behme
2011-12-20 8:24 ` Russell King - ARM Linux
2011-12-21 17:59 ` Fabio Estevam
2011-12-21 18:07 ` Fabio Estevam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EC3B844.3060402@gmail.com \
--to=robherring2@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.