All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Vrabel <david.vrabel@citrix.com>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: Michal Simek <monstr@monstr.eu>,
	"linux-next@vger.kernel.org" <linux-next@vger.kernel.org>,
	"sfr@canb.auug.org.au" <sfr@canb.auug.org.au>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] mm: Fix alloc_vm_area for noMMU system
Date: Wed, 16 Nov 2011 14:01:28 +0000	[thread overview]
Message-ID: <4EC3C238.40103@citrix.com> (raw)
In-Reply-To: <20111116135900.GB6958@phenom.dumpdata.com>

On 16/11/11 13:59, Konrad Rzeszutek Wilk wrote:
> On Wed, Nov 16, 2011 at 08:51:02AM +0100, Michal Simek wrote:
>> Patch:
>> "xen: map foreign pages for shared rings by updating the PTEs directly"
>> (sha1: 5149c0d53f6959d6ab87b4702d544b17ebdc783e) changed number
>> of argument for alloc_vm_area but forget to change it for noMMU systems.
>> This patch fix it.
> 
> Duh!
>>
>> CC: David Vrabel <david.vrabel@citrix.com>
>> CC: Andrew Morton <akpm@linux-foundation.org>
>> CC: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> 
> Yes, please. Thank you!

Konrad, I would suggest folding this into the original patch to avoid
breaking bisects for noMMU users unnecessarily.

David

>> Signed-off-by: Michal Simek <monstr@monstr.eu>
>>
>> ---
>> It is for linux-next tree.
>>
>> Michal
>> ---
>>  mm/nommu.c |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/mm/nommu.c b/mm/nommu.c
>> index 73419c5..b982290 100644
>> --- a/mm/nommu.c
>> +++ b/mm/nommu.c
>> @@ -454,7 +454,7 @@ void  __attribute__((weak)) vmalloc_sync_all(void)
>>   *	between processes, it syncs the pagetable across all
>>   *	processes.
>>   */
>> -struct vm_struct *alloc_vm_area(size_t size)
>> +struct vm_struct *alloc_vm_area(size_t size, pte_t **ptes)
>>  {
>>  	BUG();
>>  	return NULL;
>> -- 
>> 1.7.5.4

  reply	other threads:[~2011-11-16 14:01 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-16  7:51 [PATCH] mm: Fix alloc_vm_area for noMMU system Michal Simek
2011-11-16 13:59 ` Konrad Rzeszutek Wilk
2011-11-16 14:01   ` David Vrabel [this message]
2011-11-16 14:18     ` Konrad Rzeszutek Wilk
2011-11-16 14:25       ` Michal Simek
2011-11-16 15:32         ` Konrad Rzeszutek Wilk
2011-11-16 14:11 ` Konrad Rzeszutek Wilk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EC3C238.40103@citrix.com \
    --to=david.vrabel@citrix.com \
    --cc=akpm@linux-foundation.org \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-next@vger.kernel.org \
    --cc=monstr@monstr.eu \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.