From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Golle Date: Wed, 16 Nov 2011 15:29:28 +0100 Subject: [ath9k-devel] [PATCH v0 3/6] support for antenna configuration profiles In-Reply-To: References: <20111114130351.GA3132@localhost> Message-ID: <4EC3C8C8.7080706@allnet.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: ath9k-devel@lists.ath9k.org On 11/14/2011 03:44 PM, Adrian Chadd wrote > I'd personally suggest not overriding the pModal EEPROM entry with > your currently configured antenna profile. > You have a perfectly good accessor method, why not use that? As far as I can see the value stored in pModal->antCtrlCommon isn't actually used anywhere besides in ath9k_hw_4k_set_board_values, which is only called once during the init on module load. So not changing it at all and only setting the AR_PHY_SWITCH_COM register should be fine. Agree?